Clarify duplicate instrument registration scope to be a MeterProvider#3538
Merged
jmacd merged 4 commits intoopen-telemetry:mainfrom Jun 27, 2023
Merged
Clarify duplicate instrument registration scope to be a MeterProvider#3538jmacd merged 4 commits intoopen-telemetry:mainfrom
jmacd merged 4 commits intoopen-telemetry:mainfrom
Conversation
MrAlias
added
the
editorial
2 tasks
jack-berg
approved these changes
Jun 5, 2023
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
I would think that if the meters aren't from the same MeterProvider, they're not identical. But upon further inspection, the way we define "identical" doesn't include the meterprovider which produced it. Therefore, I think this change is a good one as it reduced ambiguity for a corner case.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
jsuereth
approved these changes
Jun 27, 2023
jmacd
approved these changes
Jun 27, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…open-telemetry#3538) Currently the specification seems to implicitly imply a duplicate instrument registration occurs across identical Meters from the same MeterProvider. This change makes that fact explicit. The alternative, having duplicate instrument registrations occur across all MeterProvides, seems unlikely the original intent. That would require global tracking beyond the scope of a MeterProvider, and the MeterProvider is stated to be the main source of configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the specification seems to implicitly imply a duplicate instrument registration occurs across identical Meters from the same MeterProvider. This change makes that fact explicit.
The alternative, having duplicate instrument registrations occur across all MeterProvides, seems unlikely the original intent. That would require global tracking beyond the scope of a MeterProvider, and the MeterProvider is stated to be the main source of configuration.