feat(exporters): add user-agent enrichment #4560
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
trentm
approved these changes
Jun 18, 2025
specification/protocol/exporter.md
Outdated
| @@ -208,6 +208,21 @@ OTel-OTLP-Exporter-Python/1.2.3 | |||
|
|
|||
| The format of the header SHOULD follow [RFC 7231][rfc-7231]. The conventions used for specifying the OpenTelemetry SDK language and version are available in the [Resource semantic conventions][resource-semconv]. | |||
|
|
|||
| Exporters MAY expose a configuration option to append a product identifier to the User-Agent | |||
| header as defined in [RFC 7231][rfc-7231]. Such option should not be available as | |||
There was a problem hiding this comment.
SHOULD NOT (even MUST NOT?)
There was a problem hiding this comment.
I agree with MUST NOT. Thanks @carlosalberto :)
commit d7d96d7
|
Maybe Collector folks should review this too @mx-psi ? |
|
My understanding is that Collector components are not, as a general rule, bound by the spec. I guess we can add this to our coding guidelines in the Collector as well if it gets approved here to make sure it is followed |
…telemetry-specification into enrich-user-agent-header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4479
Changes
Document that exporters may allow a
user-agentoption to append a product identifier to the exporter User Agent header. such option is only available via local var (not environment)For non-trivial changes, follow the change proposal process.
CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary