Repository navigation
Conversation
semantic-conventions-genai#571 replaces gen_ai.invoke_agent.internal and gen_ai.invoke_workflow.internal with gen_ai.invocation.internal and adds the invoke_runner operation. Keep the old types so the current registry still classifies; span kind keeps only the types the pinned model declares.
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-17 01:49 UTC Review the latest changes. Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused mappings preserve registry compatibility, and no blocking issues were identified.
0 open findings
What changed in this PR
Adds support for gen_ai.invocation.internal in GenAI span classification while retaining legacy mappings for the pinned registry.
Changes:
- Maps agent, workflow, and runner operations to the unified internal span type.
- Adds identifying attributes for unified invocations.
- Tests unified classification and preserves client-agent classification.
| File | Description |
|---|---|
| tools/gen-ai/runner/tests/test_genai_coverage.py | Tests unified invocation classification. |
| tools/gen-ai/runner/src/genai_conformance/_coverage.py | Adds unified operation and attribute mappings alongside legacy types. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semantic-conventions-genai#571 replaces
gen_ai.invoke_agent.internalandgen_ai.invoke_workflow.internalwithgen_ai.invocation.internal, and adds theinvoke_runneroperation (ADK and OpenAI AgentsRunner.run).This maps
invoke_agent,invoke_workflow, andinvoke_runnertogen_ai.invocation.internal. The old types stay, so the currently pinned registry classifies as before: span kind already keeps only the types the pinned model declares.