.count metric naming convention only applies to UpDownCounters#107
Merged
reyang merged 11 commits intoopen-telemetry:mainfrom Jul 25, 2023
Merged
.count metric naming convention only applies to UpDownCounters#107reyang merged 11 commits intoopen-telemetry:mainfrom
.count metric naming convention only applies to UpDownCounters#107reyang merged 11 commits intoopen-telemetry:mainfrom
Conversation
trask
changed the title
.count metric naming convention only applies to UpDownCounters
Member
Author
|
pinging @reyang @jack-berg @jsuereth @jmacd @MrAlias @gouthamve who approved this same PR before the repo split (and @joaopgrassi who commented on it) |
reyang
approved these changes
Jun 15, 2023
dashpole
approved these changes
Jun 23, 2023
Contributor
dashpole
left a comment
dashpole
left a comment
There was a problem hiding this comment.
I agree with the conclusion, with a few nits on the rationale provided
jsuereth
approved these changes
Jun 28, 2023
Member
|
@trask would you resolve the merge conflicts? I think it's time to get this merged. |
dashpole
reviewed
Jul 25, 2023
MrAlias
approved these changes
Jul 25, 2023
dashpole
approved these changes
Jul 25, 2023
rapphil
pushed a commit
to rapphil/semantic-conventions
that referenced
this pull request
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-specification#3457
(port of open-telemetry/opentelemetry-specification#3493)