Port, address clarifications#289
Merged
reyang merged 17 commits intoopen-telemetry:mainfrom Sep 29, 2023
Merged
Conversation
joaopgrassi
reviewed
Aug 29, 2023
joaopgrassi
reviewed
Aug 30, 2023
Co-authored-by: Joao Grassi <joao@joaograssi.com>
jsuereth
approved these changes
Aug 30, 2023
trask
approved these changes
Aug 31, 2023
Oberon00
commented
Aug 31, 2023
joaopgrassi
approved these changes
Aug 31, 2023
lmolkova
approved these changes
Sep 6, 2023
lmolkova
reviewed
Sep 26, 2023
Member
Author
|
Is there any blocker for merging this? I resolved the old conversations, IMHO this is ready. |
Member
@open-telemetry/specs-semconv-maintainers bump |
This was referenced Sep 29, 2023
Merged
breedx-splk
pushed a commit
to breedx-splk/semantic-conventions
that referenced
this pull request
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #250
Changes
network.transportwhen reporting port numbersMerge requirement checklist
[ ] schema-next.yaml updated with changes to existing conventions.