Allow adding a description when using opt_in requirement level
#392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuereth
reviewed
Sep 30, 2024
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
I agree with this change!
3 tasks
lmolkova
approved these changes
Oct 1, 2024
Member
lmolkova
left a comment
lmolkova
left a comment
There was a problem hiding this comment.
Schema changes look great to me. Thanks for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bumped into this while working on open-telemetry/semantic-conventions#474. I want to change a requirement level to
opt_inand add a description to it, but I can't because the schema doesn't allow it.