-
Notifications
You must be signed in to change notification settings - Fork 56
build: add cross-compile support #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=====================================
Coverage 73.9% 73.9%
=====================================
Files 50 50
Lines 3911 3911
=====================================
Hits 2894 2894
Misses 1017 1017 ☔ View full report in Codecov by Sentry. |
|
After a bit of wrestling with dynamically linked libraries (back to musl), it's working now. I successfully build on amd64 for amd64 and arm64, and ran each image without arguments, resulting in the successful output of the help text in each case. This is sufficient to verify that compilation and linking completed successfully. |
jsuereth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the fixes!!!
The build currently relies on QEMU emulation for arm64 builds (#346). This is slow.
This change uses Rust's ability to cross-compile for different platforms instead of relying on emulation, resulting in much faster builds.
Expected improvement is from ≈1h25m to <10m. Local cross-platform builds took about 3-7 minutes for me.