Deprecate deprecated stability level #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@open-telemetry/weaver-approvers could I get some eyes on this? |
jerbly
requested changes
Mar 12, 2025
Contributor
jerbly
left a comment
jerbly
left a comment
There was a problem hiding this comment.
This makes sense to me if we're happy to raise the minimum supported version. But, we should have an entry in CHANGELOG.md that states this.
lmolkova
force-pushed
the
remove-deprecated-stability
branch
from
8f8865b to
a449a18
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=====================================
Coverage 74.2% 74.3%
=====================================
Files 57 57
Lines 4578 4595 +17
=====================================
+ Hits 3399 3415 +16
- Misses 1179 1180 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Looks good to me but agree on having a changelog entry for this. |
jsuereth
approved these changes
Mar 21, 2025
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
Approval contingent on changelog.
lmolkova
changed the title
lmolkova
force-pushed
the
remove-deprecated-stability
branch
from
c227070 to
ca8555d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semconv don't use
stability: deprecatedfor 1+ years (since version 1.24.0) - open-telemetry/semantic-conventions#588. This is necessary to know if deprecated attribute was stable when it was deprecated (and therefore must be generated in semconv artifact) or it was experimental and does not have to be generated.Having it in weaver is not necessary and misleading. Let's remove it.