Skip to content

Conversation

@jerbly
Copy link
Contributor

@jerbly jerbly commented Mar 23, 2025

This will fix #646.

💥 BREAKING CHANGE 💥 - Upgrade to version 0.4.0 of regorus requires all v0 policies to be modified. Policy upgrade instructions here may help.

@jerbly jerbly requested a review from a team as a code owner March 23, 2025 19:38
@codecov
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.2%. Comparing base (a9f9e84) to head (548ecaa).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #651   +/-   ##
=====================================
  Coverage   74.2%   74.2%           
=====================================
  Files         57      57           
  Lines       4578    4578           
=====================================
  Hits        3399    3399           
  Misses      1179    1179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jerbly
Copy link
Contributor Author

jerbly commented Mar 24, 2025

Hit a snag with this PR:

regorus 0.3+ has a dependency on constant_time_eq-0.4.2 which requires edition 2024.

cargo-check-external-types latest version requires a nightly build, the last known working is nightly-2024-10-29. This version does not support edition 2024. I've tried later ones and they fail:

The version of rustdoc being used produces JSON format version 37, but this tool requires format version 30. This can happen if the locally installed version of rustdoc doesn't match the rustdoc JSON types from the rustdoc-types crate.

If this occurs with the latest Rust nightly and the latest version of this tool, then this is a bug, and the tool needs to be upgraded to the latest format version.

Otherwise, you'll need to determine a Rust nightly version that matches this tool's supported format version (or vice versa).

So, as written, this is a bug in cargo-check-external-types. This leaves us in a stalemate.

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerbly jerbly merged commit 8d65bd8 into open-telemetry:main Mar 24, 2025
24 checks passed
@jerbly jerbly deleted the fix-regorus-0.3 branch March 24, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants