-
Notifications
You must be signed in to change notification settings - Fork 56
Upgrade regorus to 0.4 #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
=====================================
Coverage 74.2% 74.2%
=====================================
Files 57 57
Lines 4578 4578
=====================================
Hits 3399 3399
Misses 1179 1179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hit a snag with this PR: regorus 0.3+ has a dependency on constant_time_eq-0.4.2 which requires edition 2024. cargo-check-external-types latest version requires a nightly build, the last known working is
So, as written, this is a bug in cargo-check-external-types. This leaves us in a stalemate. |
lquerel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This will fix #646.
💥 BREAKING CHANGE 💥 - Upgrade to version 0.4.0 of regorus requires all v0 policies to be modified. Policy upgrade instructions here may help.