Filter based on deprecation, stability, and annotations in signal JQ helpers #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
commented
Aug 7, 2025
lmolkova
commented
Aug 7, 2025
Member
Author
|
@MrAlias, could you please take a look? I assume you'd expect |
lmolkova
commented
Aug 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
=====================================
Coverage 77.7% 77.7%
=====================================
Files 76 76
Lines 5924 5924
=====================================
Hits 4603 4603
Misses 1321 1321 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lquerel
reviewed
Aug 8, 2025
Yeah, that sounds ideal. 👍 |
pellared
added a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Aug 12, 2025
- Remove temporary fix to filter out deprecated metrics (addressed in open-telemetry/weaver#870) - Handle empty briefs gracefully - Handle empty attributes gracefully - Regenerate v1.36.0 semconv to fix docs [Weaver v0.17.0 release](https://github.com/open-telemetry/weaver/releases/tag/v0.17.0) Follow up to #7163 --------- Co-authored-by: Robert Pająk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #847 - applies stability, deprecation, annotations filters to signals in JQ helper methods and to attribute references under them.