-
Notifications
You must be signed in to change notification settings - Fork 56
Fix error messages for unversioned files. version: ... syntax will need fixed up later
#880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error messages for unversioned files. version: ... syntax will need fixed up later
#880
Conversation
version: ... syntax will need fixed up later
jerbly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to bring back the prior behaviour. Needs a changelog entry.
lquerel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
=======================================
+ Coverage 77.7% 77.9% +0.2%
=======================================
Files 76 76
Lines 5936 5956 +20
=======================================
+ Hits 4616 4644 +28
+ Misses 1320 1312 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes unversioned file error messages, versioned files still get horrible results.
Example new (well old, but returned) error message:
However, once you add the version flag, you're back to bad error messages:
or even worse:
Will fix this up as part of V2 schema efforts.