Made zip type generic#704
Merged
edi9999 merged 1 commit intoopen-xml-templating:masterfrom Mar 3, 2023
oleksandr-danylchenko:specific-zip-type
Merged
Made zip type generic#704edi9999 merged 1 commit intoopen-xml-templating:masterfrom oleksandr-danylchenko:specific-zip-type
zip type generic#704edi9999 merged 1 commit intoopen-xml-templating:masterfrom
oleksandr-danylchenko:specific-zip-type
Conversation
Member
|
Thanks a lot , very cool merge request, it will indeed be useful to autocomplete after the "getZip()" this way ! Thanks ! Will publish this soon ! |
Member
|
Published in 3.34.3 |
Contributor
Author
|
Thank you 🤝 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, all the types of the
zipwereany. It doesn't allow using of thePizZipor other archivers with type confidence. And IDE pulls types from random places when you try usinggetZip:In this PR I made the type of passed zip generic and inferrable which will improve the DX and will prevent
as PizZipstatements in the code.