This repository was archived by the owner on Mar 21, 2025. It is now read-only.
Fixes DOM text reinterpreted as HTML vulnerability detected by CodeQL #3527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix creates jQuery objects for each HTML element and sets their attributes and text content separately, which ensures that no untrusted string can be interpreted as HTML. This way, even if inputId or $(this).text() are controlled by a user and contain malicious script, they will be treated as plain text and not executed as script which prevents injection attacks.
Related issues and discussion
#3526
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
[] Validate the JS and HTML files with
grunt validateto detect errors and potential problems in JavaScript code.giving network error "grunt validate" giving network error #3519
[] Run the tests by opening
test/SpecRunner.htmlin the browser to make sure you didn't break anything.If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
community-app/Contributing.md.