Skip to content

Conversation

@skuschel
Copy link
Member

@skuschel skuschel commented Jan 7, 2016

Fix the outdated record reading example (python).

code checked with openPMD example data
@ax3l ax3l added the revision change backwards-compatible, stylistic change (e.g. typos) label Jan 7, 2016
@ax3l ax3l self-assigned this Jan 7, 2016
@ax3l ax3l added this to the 1.0.1: Typo and Wording Changes milestone Jan 7, 2016
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, interesting. I never used .value on h5py.Dateset types before. It returns the numpy.ndarray directly, cool. (Docstring: Alias for dataset[()])
yes, that is way more general then the example assuming a 1D array [:]. Alternatively, [()] would be the same says the docstring.

@ax3l
Copy link
Member

ax3l commented Jan 7, 2016

@skuschel looks good to me, I let @RemiLehe have a look too and then we can merge it.

Thanks a lot for fixing the example, that is great! ✨

@ax3l ax3l changed the title Fix python example Particle Position Reading: Fix Python Example Jan 7, 2016
@RemiLehe
Copy link
Member

RemiLehe commented Jan 7, 2016

The corrections are fine with me. @skuschel : Thanks a lot for spotting and correcting these mistakes !
@ax3l : You can merge it.

ax3l added a commit that referenced this pull request Jan 7, 2016
Particle Position Reading: Fix Python Example
@ax3l ax3l merged commit 67a6eb6 into openPMD:upcoming-1.0.1 Jan 7, 2016
@ax3l ax3l removed this from the 1.0.1: Typo and Wording Changes milestone Nov 24, 2017
@ax3l ax3l mentioned this pull request Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

revision change backwards-compatible, stylistic change (e.g. typos)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants