Skip to content

feat(core): add watchdog runtime and prompts#13678

Closed
friel-openai wants to merge 31 commits intodev/friel/subagent-inbox-injectionfrom
dev/friel/watchdog-runtime-and-prompts
Closed

feat(core): add watchdog runtime and prompts#13678
friel-openai wants to merge 31 commits intodev/friel/subagent-inbox-injectionfrom
dev/friel/watchdog-runtime-and-prompts

Conversation

@friel-openai
Copy link
Copy Markdown
Contributor

@friel-openai friel-openai commented Mar 6, 2026

Summary

  • add watchdog runtime support and lifecycle management for agent threads
  • add watchdog-specific prompts and role configuration, including model overrides
  • preserve watchdog-facing control surfaces such as list_agents, close_agent, and parent compaction hooks
  • require every watchdog check-in to wake the owner thread, either through explicit send_input or runtime fallback delivery

Stack

Notes

  • this branch is intentionally stacked on dev/friel/subagent-inbox-injection
  • watchdog helper wake-up reliability depends on the agent inbox injection machinery from feat(agents): enable subagent inbox delivery #13657
  • the branch is reviewable in this stacked form; main does not contain the inbox delivery path it relies on

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ad5302861

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/agent/control.rs
friel-openai added a commit that referenced this pull request Mar 6, 2026
friel-openai added a commit that referenced this pull request Mar 6, 2026
Adjust the watchdog compaction regression test to match the new duplicate-blocking behavior instead of pre-seeding the in-progress set.

Also relax the MCP codex-tool assertion so it checks for developer instructions by substring, which keeps the test valid when branch-added root/subagent prompt text is coalesced into the same developer message.
friel-openai added a commit that referenced this pull request Mar 6, 2026
Allow subagent spawning at the configured max depth by only disabling the agents feature when child depth exceeds the limit.

Update the affected codex-core tests to match the current role spec output and context-free spawn config behavior, and keep the depth-boundary spawn test on the plain spawn path while asserting that the spawned thread is actually registered.
friel-openai added a commit that referenced this pull request Mar 6, 2026
friel-openai added a commit that referenced this pull request Mar 6, 2026
friel-openai added a commit that referenced this pull request Mar 6, 2026
Adjust the watchdog compaction regression test to match the new duplicate-blocking behavior instead of pre-seeding the in-progress set.

Also relax the MCP codex-tool assertion so it checks for developer instructions by substring, which keeps the test valid when branch-added root/subagent prompt text is coalesced into the same developer message.
@friel-openai friel-openai force-pushed the dev/friel/watchdog-runtime-and-prompts branch from 8aa5c15 to a6154b1 Compare March 6, 2026 23:09
friel-openai added a commit that referenced this pull request Mar 6, 2026
Allow subagent spawning at the configured max depth by only disabling the agents feature when child depth exceeds the limit.

Update the affected codex-core tests to match the current role spec output and context-free spawn config behavior, and keep the depth-boundary spawn test on the plain spawn path while asserting that the spawned thread is actually registered.
friel-openai added a commit that referenced this pull request Mar 6, 2026
friel-openai added a commit that referenced this pull request Mar 8, 2026
friel-openai added a commit that referenced this pull request Mar 8, 2026
Adjust the watchdog compaction regression test to match the new duplicate-blocking behavior instead of pre-seeding the in-progress set.

Also relax the MCP codex-tool assertion so it checks for developer instructions by substring, which keeps the test valid when branch-added root/subagent prompt text is coalesced into the same developer message.
friel-openai added a commit that referenced this pull request Mar 8, 2026
Allow subagent spawning at the configured max depth by only disabling the agents feature when child depth exceeds the limit.

Update the affected codex-core tests to match the current role spec output and context-free spawn config behavior, and keep the depth-boundary spawn test on the plain spawn path while asserting that the spawned thread is actually registered.
friel-openai added a commit that referenced this pull request Mar 8, 2026
@friel-openai friel-openai force-pushed the dev/friel/watchdog-runtime-and-prompts branch from e1875e7 to 421ed3d Compare March 8, 2026 08:01
friel-openai added a commit that referenced this pull request Mar 8, 2026
friel-openai added a commit that referenced this pull request Mar 8, 2026
Adjust the watchdog compaction regression test to match the new duplicate-blocking behavior instead of pre-seeding the in-progress set.

Also relax the MCP codex-tool assertion so it checks for developer instructions by substring, which keeps the test valid when branch-added root/subagent prompt text is coalesced into the same developer message.
friel-openai added a commit that referenced this pull request Mar 8, 2026
Allow subagent spawning at the configured max depth by only disabling the agents feature when child depth exceeds the limit.

Update the affected codex-core tests to match the current role spec output and context-free spawn config behavior, and keep the depth-boundary spawn test on the plain spawn path while asserting that the spawned thread is actually registered.
friel-openai added a commit that referenced this pull request Mar 8, 2026
@friel-openai friel-openai force-pushed the dev/friel/watchdog-runtime-and-prompts branch from 421ed3d to 2248ceb Compare March 8, 2026 22:12
friel-openai added a commit that referenced this pull request Mar 9, 2026
friel-openai added a commit that referenced this pull request Mar 9, 2026
Adjust the watchdog compaction regression test to match the new duplicate-blocking behavior instead of pre-seeding the in-progress set.

Also relax the MCP codex-tool assertion so it checks for developer instructions by substring, which keeps the test valid when branch-added root/subagent prompt text is coalesced into the same developer message.
friel-openai added a commit that referenced this pull request Mar 9, 2026
Allow subagent spawning at the configured max depth by only disabling the agents feature when child depth exceeds the limit.

Update the affected codex-core tests to match the current role spec output and context-free spawn config behavior, and keep the depth-boundary spawn test on the plain spawn path while asserting that the spawned thread is actually registered.
friel-openai added a commit that referenced this pull request Mar 9, 2026
@friel-openai friel-openai force-pushed the dev/friel/watchdog-runtime-and-prompts branch from 9b5b0ff to 573eea7 Compare March 9, 2026 00:03
@friel-openai friel-openai changed the base branch from main to dev/friel/subagent-inbox-injection March 9, 2026 00:55
@friel-openai friel-openai force-pushed the dev/friel/watchdog-runtime-and-prompts branch from 1eee180 to 08dad72 Compare March 28, 2026 23:22
friel-openai and others added 21 commits March 29, 2026 17:04
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
…parent-model' into repair/watchdog-prompt-layering
@github-actions
Copy link
Copy Markdown
Contributor

Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant