Skip to content

Add parent-scoped guardian approval review events #15265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charley-oai wants to merge 6 commits into from
Closed

Add parent-scoped guardian approval review events #15265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb24275
Add parent-scoped guardian approval review events
charley-oai Mar 20, 2026
b61c1fc
Relax guardian approval review wording
charley-oai Mar 21, 2026
adcbd45
Remove guardian review change-soon wording
charley-oai Mar 21, 2026
1106793
app-server: handle guardian review notifications in tui
charley-oai Mar 21, 2026
6762703
don't show double guardian events in tui_app_server
charley-oai Mar 21, 2026
d8f6a43
app-server: dedupe legacy guardian review fallbacks
charley-oai Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
278 changes: 275 additions & 3 deletions codex-rs/app-server-protocol/schema/json/ServerNotification.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,6 +725,56 @@
}
]
},
"CommandExecutionGuardianApprovalReviewCompletedNotification": {
"description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item.",
"properties": {
"action": true,
"itemId": {
"type": "string"
},
"review": {
"$ref": "#/definitions/GuardianApprovalReview"
},
"threadId": {
"type": "string"
},
"turnId": {
"type": "string"
}
},
"required": [
"itemId",
"review",
"threadId",
"turnId"
],
"type": "object"
},
"CommandExecutionGuardianApprovalReviewStartedNotification": {
"description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item.",
"properties": {
"action": true,
"itemId": {
"type": "string"
},
"review": {
"$ref": "#/definitions/GuardianApprovalReview"
},
"threadId": {
"type": "string"
},
"turnId": {
"type": "string"
}
},
"required": [
"itemId",
"review",
"threadId",
"turnId"
],
"type": "object"
},
"CommandExecutionOutputDeltaNotification": {
"properties": {
"delta": {
Expand Down Expand Up @@ -934,6 +984,56 @@
],
"type": "object"
},
"FileChangeGuardianApprovalReviewCompletedNotification": {
"description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item.",
"properties": {
"action": true,
"itemId": {
"type": "string"
},
"review": {
"$ref": "#/definitions/GuardianApprovalReview"
},
"threadId": {
"type": "string"
},
"turnId": {
"type": "string"
}
},
"required": [
"itemId",
"review",
"threadId",
"turnId"
],
"type": "object"
},
"FileChangeGuardianApprovalReviewStartedNotification": {
"description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item.",
"properties": {
"action": true,
"itemId": {
"type": "string"
},
"review": {
"$ref": "#/definitions/GuardianApprovalReview"
},
"threadId": {
"type": "string"
},
"turnId": {
"type": "string"
}
},
"required": [
"itemId",
"review",
"threadId",
"turnId"
],
"type": "object"
},
"FileChangeOutputDeltaNotification": {
"properties": {
"delta": {
Expand Down Expand Up @@ -1081,7 +1181,7 @@
"type": "object"
},
"GuardianApprovalReview": {
"description": "[UNSTABLE] Temporary guardian approval review payload used by `item/autoApprovalReview/*` notifications. This shape is expected to change soon.",
"description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.",
"properties": {
"rationale": {
"type": [
Expand Down Expand Up @@ -1349,7 +1449,7 @@
"type": "object"
},
"ItemGuardianApprovalReviewCompletedNotification": {
"description": "[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.",
"description": "Deprecated when app-server also emits the parent item-specific `item/*/guardianApprovalReview/*` notification for the same review. Continue handling this payload as a fallback for review kinds that are not yet parent-scoped (for example, network approvals / `network_access`).\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.",
"properties": {
"action": true,
"review": {
Expand All @@ -1374,7 +1474,7 @@
"type": "object"
},
"ItemGuardianApprovalReviewStartedNotification": {
"description": "[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.",
"description": "Deprecated when app-server also emits the parent item-specific `item/*/guardianApprovalReview/*` notification for the same review. Continue handling this payload as a fallback for review kinds that are not yet parent-scoped (for example, network approvals / `network_access`).\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.",
"properties": {
"action": true,
"review": {
Expand Down Expand Up @@ -1479,6 +1579,56 @@
],
"type": "object"
},
"McpToolCallGuardianApprovalReviewCompletedNotification": {
"description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item.",
"properties": {
"action": true,
"itemId": {
"type": "string"
},
"review": {
"$ref": "#/definitions/GuardianApprovalReview"
},
"threadId": {
"type": "string"
},
"turnId": {
"type": "string"
}
},
"required": [
"itemId",
"review",
"threadId",
"turnId"
],
"type": "object"
},
"McpToolCallGuardianApprovalReviewStartedNotification": {
"description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item.",
"properties": {
"action": true,
"itemId": {
"type": "string"
},
"review": {
"$ref": "#/definitions/GuardianApprovalReview"
},
"threadId": {
"type": "string"
},
"turnId": {
"type": "string"
}
},
"required": [
"itemId",
"review",
"threadId",
"turnId"
],
"type": "object"
},
"McpToolCallProgressNotification": {
"properties": {
"itemId": {
Expand Down Expand Up @@ -4043,6 +4193,127 @@
"type": "object"
},
{
"properties": {
"method": {
"enum": [
"item/commandExecution/guardianApprovalReview/started"
],
"title": "Item/commandExecution/guardianApprovalReview/startedNotificationMethod",
"type": "string"
},
"params": {
"$ref": "#/definitions/CommandExecutionGuardianApprovalReviewStartedNotification"
}
},
"required": [
"method",
"params"
],
"title": "Item/commandExecution/guardianApprovalReview/startedNotification",
"type": "object"
},
{
"properties": {
"method": {
"enum": [
"item/commandExecution/guardianApprovalReview/completed"
],
"title": "Item/commandExecution/guardianApprovalReview/completedNotificationMethod",
"type": "string"
},
"params": {
"$ref": "#/definitions/CommandExecutionGuardianApprovalReviewCompletedNotification"
}
},
"required": [
"method",
"params"
],
"title": "Item/commandExecution/guardianApprovalReview/completedNotification",
"type": "object"
},
{
"properties": {
"method": {
"enum": [
"item/fileChange/guardianApprovalReview/started"
],
"title": "Item/fileChange/guardianApprovalReview/startedNotificationMethod",
"type": "string"
},
"params": {
"$ref": "#/definitions/FileChangeGuardianApprovalReviewStartedNotification"
}
},
"required": [
"method",
"params"
],
"title": "Item/fileChange/guardianApprovalReview/startedNotification",
"type": "object"
},
{
"properties": {
"method": {
"enum": [
"item/fileChange/guardianApprovalReview/completed"
],
"title": "Item/fileChange/guardianApprovalReview/completedNotificationMethod",
"type": "string"
},
"params": {
"$ref": "#/definitions/FileChangeGuardianApprovalReviewCompletedNotification"
}
},
"required": [
"method",
"params"
],
"title": "Item/fileChange/guardianApprovalReview/completedNotification",
"type": "object"
},
{
"properties": {
"method": {
"enum": [
"item/mcpToolCall/guardianApprovalReview/started"
],
"title": "Item/mcpToolCall/guardianApprovalReview/startedNotificationMethod",
"type": "string"
},
"params": {
"$ref": "#/definitions/McpToolCallGuardianApprovalReviewStartedNotification"
}
},
"required": [
"method",
"params"
],
"title": "Item/mcpToolCall/guardianApprovalReview/startedNotification",
"type": "object"
},
{
"properties": {
"method": {
"enum": [
"item/mcpToolCall/guardianApprovalReview/completed"
],
"title": "Item/mcpToolCall/guardianApprovalReview/completedNotificationMethod",
"type": "string"
},
"params": {
"$ref": "#/definitions/McpToolCallGuardianApprovalReviewCompletedNotification"
}
},
"required": [
"method",
"params"
],
"title": "Item/mcpToolCall/guardianApprovalReview/completedNotification",
"type": "object"
},
{
"description": "Deprecated when app-server also emits the parent item-specific `item/*/guardianApprovalReview/*` notification for the same review. Continue handling this alias as a fallback for review kinds that are not yet parent-scoped (for example, network approvals / `network_access`).",
"properties": {
"method": {
"enum": [
Expand All @@ -4063,6 +4334,7 @@
"type": "object"
},
{
"description": "Deprecated when app-server also emits the parent item-specific `item/*/guardianApprovalReview/*` notification for the same review. Continue handling this alias as a fallback for review kinds that are not yet parent-scoped (for example, network approvals / `network_access`).",
"properties": {
"method": {
"enum": [
Expand Down
Loading
Loading