(tui): Decode percent-escaped bare local file links#16810
Merged
etraut-openai merged 2 commits intomainfrom Apr 6, 2026
Merged
(tui): Decode percent-escaped bare local file links#16810etraut-openai merged 2 commits intomainfrom
etraut-openai merged 2 commits intomainfrom
Conversation
Addresses #16622 Problem: bare local file links in TUI markdown render percent-encoded path bytes literally, unlike file:// links. Solution: decode bare path targets before local-path expansion and add regression coverage for spaces and Unicode.
etraut-openai
changed the title
fcoury-oai
approved these changes
Apr 6, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Tested before:
And after:
Code looks good as well. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #16622
Problem: bare local file links in TUI markdown render percent-encoded path bytes literally, unlike file:// links.
Solution: decode bare path targets before local-path expansion and add regression coverage for spaces and Unicode.