Improve environment setup & fix path errors & exec #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added instructions on creating a virtual environment with
conda
.Obviates the need to use
python3/pip3
. Also ensures that therequirements installation will work: there won't be any conflicts
in the environment.
Fixed the path import errors by adding
src/__init__.py
, explicitlyimporting:
from src import ..
, and by moving the executable Pythonscripts to the project's root. Updated README documentation too.
Made the
download_model.sh
script exectuable and changed it touse the first
bash
executable found on the system's$PATH
.Additionally, made the Python scripts not executable (they
should be run with
python ...
at any rate).