Skip to content

Update test #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Update test #3

wants to merge 4 commits into from

Conversation

teunbrand
Copy link

@teunbrand teunbrand commented Jul 8, 2023

Hi folks,

Apologies for the cold PR without posting an issue first.
The ggplot2 package has rewritten the guide system and, as a result, one of the test expectations no longer hold in combination with development version of ggplot2.
This PR updates that test to be compatible with both the current and development version of ggplot2.

Best,
Teun

@lcougnaud
Copy link
Member

Thanks for the PR!
When will the ggplot2 update be available in CRAN?
The previous test seems to work with the current version ggplot2 (4.4.3) in CRAN.

@teunbrand
Copy link
Author

Yes, the current tests will work fine as-is until the guide rewrite that is in the development version will be on CRAN.
When that will happen is still unclear, but probably in a month or two. This PR is just a proposal for an updated test, so that when the new version lands on CRAN, inTextSummaryTable's tests will not start failing immediately.

@teunbrand
Copy link
Author

Hi there,

I've updated this PR to reflect that latest changes in ggplot2 and the master branch.
The only change that was required is that one plot is no longer silent, which is intentional from ggplot2's side.
I'm testing instead whether the code delivers a ggplot object.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help inTextSummaryTable get out a fix if necessary.

@teunbrand
Copy link
Author

This is just a kind reminder that the release is scheduled soon.

@lcougnaud
Copy link
Member

Thanks for the notification & for the hints!
A new version of the package, including these fixes, will be released to CRAN soon.

@lcougnaud lcougnaud closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants