filter plugin for tags was not working as expected. Regex expression to check for white space needed to be changed. #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to \s+ which does a better job at dealing with whitespace between tags.
Member
|
That's clearly correct =). Thanks! |
nickstenning
added a commit
that referenced
this pull request
Aug 20, 2013
filter plugin for tags was not working as expected. Regex expression to check for white space needed to be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input.split /\s*/ was not producing the desired result. It was taking the filter input for tags and looking for each letter instead of the word. changing regex to /\s+/ seemed to fix things.