Skip to content

npm 12 follow-up - #12119

Closed
znarf wants to merge 1 commit into
mainfrom
chore/npm-12-followup
Closed

znarf wants to merge 1 commit into
mainfrom
chore/npm-12-followup

Conversation

@znarf

@znarf znarf commented Sep 16, 2026

Copy link
Copy Markdown
Member

Follow-up to #12073, aligning with opencollective/opencollective-frontend#12401.

  • CI installs npm by major, npm install -g npm@12, instead of npm@12.0.2. The lines now follow engines.npm: 12.x the way Heroku resolves it: patch and minor releases need no coordinated edits across the workflows, and the next major is a single bump alongside engines.npm. An exact pin would otherwise have drifted to an old 12.0.x for the whole major, since Renovate only touches engines.
  • Drop the packageManager field. Only Corepack reads it (disabled by default in Node 24, removed from Node 25); npm itself ignores it and actions/setup-node only uses it to toggle caching we already enable with cache: 'npm'. engines.npm with engine-strict=true plus the CI install step are what enforce the version.
  • README: nvm install && nvm use leaves the npm bundled with Node 24 (11.x), which the engine-strict check now rejects, so add the npm install --global npm@12 step.

Install npm by major (`npm@12`) instead of an exact pin in CI, so the
lines follow `engines.npm: 12.x` the way Heroku resolves it: patch
releases need no coordinated edits and the next major is a single bump.

Drop the `packageManager` field: only Corepack reads it, which is
disabled in Node 24 and gone from Node 25; `engines.npm` and the CI
install step are what enforce the version.

Document installing npm 12 after `nvm use`, since Node 24 bundles
npm 11, which the engine-strict check now rejects.
@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a491233a-8311-4440-bde9-134650938f1c

📥 Commits

Reviewing files that changed from the base of the PR and between 164e6a8 and 7c8df70.

📒 Files selected for processing (4)
  • .github/workflows/ci.yml
  • .github/workflows/e2e.yml
  • README.md
  • package.json
💤 Files with no reviewable changes (1)
  • package.json

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The packageManager pin for npm 12.0.2 was removed from package.json. The Node.js 24 prerequisite now documents a global npm 12 installation. CI and E2E workflows now install the npm 12 release without pinning version 12.0.2. The engines field remains set to Node.js 24.x and npm 12.x.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 7c8df

The npm 12 setup is aligned across documentation, package requirements, CI, and E2E workflows, with no remaining merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@znarf znarf mentioned this pull request Sep 16, 2026
@znarf znarf closed this Sep 16, 2026
@znarf
znarf deleted the chore/npm-12-followup branch September 16, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant