Repository navigation
npm 12 follow-up - #12119
npm 12 follow-up#12119znarf wants to merge 1 commit into
Conversation
Install npm by major (`npm@12`) instead of an exact pin in CI, so the lines follow `engines.npm: 12.x` the way Heroku resolves it: patch releases need no coordinated edits and the next major is a single bump. Drop the `packageManager` field: only Corepack reads it, which is disabled in Node 24 and gone from Node 25; `engines.npm` and the CI install step are what enforce the version. Document installing npm 12 after `nvm use`, since Node 24 bundles npm 11, which the engine-strict check now rejects.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The npm 12 setup is aligned across documentation, package requirements, CI, and E2E workflows, with no remaining merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #12073, aligning with opencollective/opencollective-frontend#12401.
npm install -g npm@12, instead ofnpm@12.0.2. The lines now followengines.npm: 12.xthe way Heroku resolves it: patch and minor releases need no coordinated edits across the workflows, and the next major is a single bump alongsideengines.npm. An exact pin would otherwise have drifted to an old 12.0.x for the whole major, since Renovate only touchesengines.packageManagerfield. Only Corepack reads it (disabled by default in Node 24, removed from Node 25); npm itself ignores it andactions/setup-nodeonly uses it to toggle caching we already enable withcache: 'npm'.engines.npmwithengine-strict=trueplus the CI install step are what enforce the version.nvm install && nvm useleaves the npm bundled with Node 24 (11.x), which the engine-strict check now rejects, so add thenpm install --global npm@12step.