libcontainer: isolate libcontainer/devices

[thaJeztah]

Move the Device-related types to libcontainer/devices, so that the package can be used in isolation. Aliases have been created in libcontainer/configs for backward compatibility.

[crosbymichael]

+1, I'm good with the refactoring

[thaJeztah]

oh! forgot to move it out of draft; wanted to be sure it didn't explode; moving to "ready for review"

[thaJeztah]

@kolyshkin LGTY?

[kolyshkin]

LGTM overall. I think we may drop "Deivce" prefix from a few IDs, e.g.

configs.DeviceType -> devices.Type
config.DevicePermissions -> devices.Perms
configs.DeviceRule -> devices.Rule

and so on (not all of them though)

[thaJeztah]

@kolyshkin @AkihiroSuda @crosbymichael updated; PTAL

Changed:

• devices.DevicePermissions -> devices.Permissions
• devices.DeviceType -> devices.Type
• devices.DeviceRule -> devices.Rule

[thaJeztah]

Hm.. some issue with the SUSE repositories?

Step 12/23 : RUN echo 'deb http://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_Unstable/ /' > /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list     && wget -nv https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/Debian_Unstable/Release.key -O- | sudo apt-key add -     && apt-get update     && apt-get install -y --no-install-recommends skopeo     && rm -rf /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list     && apt-get clean     && rm -rf /var/cache/apt /var/lib/apt/lists/*;
 ---> Running in 7b59184181e1
Warning: apt-key output should not be parsed (stdout is not a terminal)
https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_Unstable/Release.key:
2020-11-19 11:08:33 ERROR 404: Not Found.
gpg: no valid OpenPGP data found.
The command '/bin/sh -c echo 'deb http://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_Unstable/ /' > /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list     && wget -nv https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/Debian_Unstable/Release.key -O- | sudo apt-key add -     && apt-get update     && apt-get install -y --no-install-recommends skopeo     && rm -rf /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list     && apt-get clean     && rm -rf /var/cache/apt /var/lib/apt/lists/*;' returned a non-zero code: 2
Makefile:62: recipe for target 'runcimage' failed
make: *** [runcimage] Error 2
The command "make clean ci cross" exited with 2.
cache.2
store build cache

[thaJeztah]

let me try if close/open kicks CI here

[thaJeztah]

Failing again 😞

The command '/bin/sh -c echo 'deb http://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_Unstable/ /' > /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list     && wget -nv https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/Debian_Unstable/Release.key -O- | sudo apt-key add -     && apt-get update     && apt-get install -y --no-install-recommends skopeo     && rm -rf /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list     && apt-get clean     && rm -rf /var/cache/apt /var/lib/apt/lists/*;' returned a non-zero code: 2
Makefile:62: recipe for target 'runcimage' failed
make: *** [runcimage] Error 2
The command "make clean ci cross" exited with 2.
cache.2
store build cache

@cyphar any ideas? is this an issue with the opensuse package repos?

[thaJeztah]

Rebased, as CI should now be fixed by #2686

@AkihiroSuda @kolyshkin @crosbymichael ptal

[thaJeztah]

Rebased again, as CI seemed to be stuck in "preparing" state

[kolyshkin]

travis timed out:

ok 12 checkpoint and restore
ok 13 checkpoint and restore (cgroupns)
ok 14 checkpoint --pre-dump and restore

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

I have seen this before (in cri-o/cri-o), apparently they gradually tighten the resources and thus we need to increase the timeout :(

[kolyshkin]

For now I've just restarted the job

[kolyshkin]

LGTM

[kolyshkin]

@AkihiroSuda @mrunalp PTAL