ci: don't fail CI if criu-dev test fails#5012
Merged
Merged
Conversation
kolyshkin
marked this pull request as ready for review
November 13, 2025 18:13
kolyshkin
force-pushed
the
criu-dev-ignore-fails
branch
from
November 13, 2025 18:13
6296856 to
247faf5
Compare
Contributor
Author
|
@opencontainers/runc-maintainers any opinions? |
AkihiroSuda
approved these changes
Dec 3, 2025
rata
enabled auto-merge
December 4, 2025 13:27
rata
approved these changes
Dec 4, 2025
rata
left a comment
rata
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks!
Not breaking runc CI for criu-dev makes sense to me. Also, criu could add some of these tests to their CI if they wanted to.
Restarted the failed check and enabled auto-merge. Hopefully it will be merged soon :)
Member
|
CI still failing :( |
In view of recent criu-dev failure, let's not fail the required "all-done" job when criu-dev tests fail. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
lifubang
force-pushed
the
criu-dev-ignore-fails
branch
from
December 5, 2025 02:54
247faf5 to
5407cfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In view of recent criu-dev failure (see checkpoint-restore/criu#2781, checkpoint-restore/criu#2819), let's not fail the required "all-done" job when criu-dev tests fail.