Update Connected component labelling bug

[yash112-lang]

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

• I agree to contribute to the project under Apache 2 License.
• To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
• The PR is proposed to the proper branch
• There is a reference to the original bug report and related work
• There is accuracy test, performance test and test data in opencv_extra repository, if applicable
  Patch to opencv_extra has the same branch name.
• The feature is well documented and sample code can be built with the project CMake

Overview

This PR fixes issue #21783

[MicheleCancilla]

You have modified the wrong line...
Faulty code:

opencv/modules/imgproc/src/connectedcomponents.cpp

Line 4343 in 56f21c4

#define condition_e c+2<w && r-1>=0 && img_row_prev[c-1]>0

[yash112-lang]

I had updated it @MicheleCancilla, sorry for the previous commit. Can you take a look at it?

[prittt]

@yash112-lang You correctly reverted the wrong change, but the original buggy line is still there. Moreover, instead of having 3 commits to fix one line of code is better to have just one (e.g. forcepushing on your repo).

[MicheleCancilla]

Edit: now it's fine!

[yash112-lang]

@yash112-lang You correctly reverted the wrong change, but the original buggy line is still there. Moreover, instead of having 3 commits to fix one line of code is better to have just one (e.g. forcepushing on your repo).
I think @prittt, the code was fine after the previous commit - Update connectedcomponents.cpp.

[prittt]

@yash112-lang You correctly reverted the wrong change, but the original buggy line is still there. Moreover, instead of having 3 commits to fix one line of code is better to have just one (e.g. forcepushing on your repo).

I think @prittt, the code was fine after the previous commit - @yash112-lang Update connectedcomponents.cpp.

@yash112-lang Yes, after your last commit it is.

To keep the history of the OpenCV repo as clean as possible, I suggest you to compress all changes (one line of code) in one single commit instead of five.

[yash112-lang]

@prittt, When trying to squash all commits into one it shows me an error message like this - "Unable to reorder. Reordering replays all commits up to the last one required for the reordering. A merge commit cannot exist among those commits." I searched on Internet also but have not found a relevant answer can you please help me to deal with it.

[alalek]

Rebased to keep 1 commit only in PR.

[alalek]

Thank you for contribution 👍

@MicheleCancilla Thank you for the review!