-
Notifications
You must be signed in to change notification settings - Fork 5.8k
license problem in descriptor.hpp #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@fcyella, thank you! Yes, this is definitely a problem. We will prepare patches to remove this code from the master and 3.4 branches shortly. |
I am going to release my company commercial production which is using LineSegmentDetector in OpenCV 3.4.3. Will this be a problem if we will not open our source code? |
You should contact with your lawyer. |
Is there a license-compatible version of this logic that will be made available? |
Seriously. I just stumbled upon this. Can't we ask them to relicense that particular piece of code? I just spent an hour trying to work around this issue just to keep my code working. |
I just saw this issue. I apologize for the problematic license on the blog post. I've updated it. I also put a copy of the code with an embedded license in github: https://github.com/randomascii/blogstuff/blob/main/FloatingPoint/CompareAsInt/CompareAsInt.cpp |
i am happy to annonce that after i send an e-mail to @rafael-grompone-von-gioi he kindly published his Computation of a NFA related to a binomial distribution code with MIT licence. He also states he will be happy to help on restoration of LDS Algorithm in OpenCV. thank you @rafael-grompone-von-gioi for your great work. |
In modules/line_descriptor/include/opencv2/line_descriptor/descriptor.hpp, a section between lines 625 and 824 that starts with "Compare doubles by relative error" That appears to come from here: http://www.ipol.im/pub/art/2012/gjmr-lsd/, which has the GNU Afero General Public License.
Seems it's not compatible with opencv_contrib's 3-clause BSD License, Will this be a problem?
The text was updated successfully, but these errors were encountered: