Skip to content

license problem in descriptor.hpp #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fcyella opened this issue Mar 1, 2019 · 8 comments
Closed

license problem in descriptor.hpp #2016

fcyella opened this issue Mar 1, 2019 · 8 comments

Comments

@fcyella
Copy link

fcyella commented Mar 1, 2019

  • OpenCV => 4.0.1
  • Operating System / Platform => Linux,
  • Compiler => gcc

In modules/line_descriptor/include/opencv2/line_descriptor/descriptor.hpp, a section between lines 625 and 824 that starts with "Compare doubles by relative error" That appears to come from here: http://www.ipol.im/pub/art/2012/gjmr-lsd/, which has the GNU Afero General Public License.
Seems it's not compatible with opencv_contrib's 3-clause BSD License, Will this be a problem?

@vpisarev
Copy link
Contributor

vpisarev commented Mar 1, 2019

@fcyella, thank you! Yes, this is definitely a problem. We will prepare patches to remove this code from the master and 3.4 branches shortly.

@chinhdd
Copy link

chinhdd commented Jun 7, 2019

I am going to release my company commercial production which is using LineSegmentDetector in OpenCV 3.4.3. Will this be a problem if we will not open our source code?
Thank you!

@alalek
Copy link
Member

alalek commented Jun 7, 2019

You should contact with your lawyer.
Don't expect legal-related answers on Internet.

@LaurentBerger
Copy link
Contributor

@alalek There is no license on this code. Original code is here and about license it's here

@JLLeitschuh
Copy link

Is there a license-compatible version of this logic that will be made available?

@AlexDaniel
Copy link

Seriously. I just stumbled upon this. Can't we ask them to relicense that particular piece of code? I just spent an hour trying to work around this issue just to keep my code working.

@randomascii
Copy link

I just saw this issue. I apologize for the problematic license on the blog post. I've updated it. I also put a copy of the code with an embedded license in github: https://github.com/randomascii/blogstuff/blob/main/FloatingPoint/CompareAsInt/CompareAsInt.cpp

@sturkmen72
Copy link
Contributor

i am happy to annonce that after i send an e-mail to @rafael-grompone-von-gioi he kindly published his Computation of a NFA related to a binomial distribution code with MIT licence. He also states he will be happy to help on restoration of LDS Algorithm in OpenCV.

thank you @rafael-grompone-von-gioi for your great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants