-
Notifications
You must be signed in to change notification settings - Fork 5.8k
aruco: conflicting documentation in estimatePoseSingleMarkers #3250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@crackwitz, to make the pose estimation for the single marker and boards ( Thanks for the issue, I've updated the documentation and tutorial. For compatibility with old codes, I can add a mode for the algorithm. |
To draw the axes in the old format, you can use this sample:
|
PR #3256 fixes docs/tutorial and add mode for old coordinate system |
Does the second picture imply that now Z points into the marker? Which order of corners is considered counter-clockwise? I'm concerned that the identifiers in #3256 are mixed up. Looking at a marker, it always used to be TL, TR, BR, BL, which I consider clockwise. Now, if X right, Y up, Z near ("old"), that's going negatively around Z. If X right Y down Z far ("new"), that's going positively around Z. I wouldn't recommend using "clockwise"/"counterclockwise" there at all. The difference isn't the order of corners but the placement (orientation) of the coordinate system. |
Documentation says:
This agrees with the implementation.
But it also says:
This, to my mind, disagrees with the previous statement. (0,0,0) is the origin, which is the center of the marker, not any of its corners. Perhaps "its own coordinate system" refers to a different coordinate system... which it should not.
I would suggest the following:
Or alternatively, to show with a diagram where and in what order the corners are.
I am doubting myself here, because recently someone reported that their code puts an axis triad at the corner of the marker... and I don't see why their code would do that (the python equivalent puts it in the center), but it would agree with the second sentence from the documentation.
The text was updated successfully, but these errors were encountered: