Add EDColor related algorithms to EdgeDrawing Class #3764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sturkmen72
force-pushed
the
edcolor
branch
2 times, most recently
from
599f9c2 to
82adc6f
Compare
sturkmen72
force-pushed
the
edcolor
branch
2 times, most recently
from
889e9c9 to
6e72f00
Compare
asmorkalov
approved these changes
Jul 8, 2024
sturkmen72
force-pushed
the
edcolor
branch
8 times, most recently
from
98bfd30 to
99fb0d3
Compare
|
@asmorkalov could you start the tests please. |
sturkmen72
force-pushed
the
edcolor
branch
4 times, most recently
from
1318118 to
447ab56
Compare
|
@sturkmen72 I see regular commits to the PR. I switched it to WIP. Please return it back, when it's ready. |
asmorkalov
changed the title
Fixed a bug where params.PFmode = true caused incorrect edge detection results. Updated edge_drawing.py to support the new EDColor feature. Created a new edge_drawing_demo.cpp for demonstrating the EDColor feature. Updated ximgproc.bib to include references for EDColor. Added tests for PFmode and EDColor in test_fld.cpp. Added CV_WRAP to Params::read and Params::write functions to expose them to Python bindings. the class NFALUT uses the code from original ED code
sturkmen72
changed the title
|
bump |
|
@asmorkalov i hope this PR will be merged before the release of OpenCV 4.12.0 let me know if something to do to facilitate code review. ( indeed i did not do so big changes after your approval ) |
asmorkalov
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #2314
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.