-
Notifications
You must be signed in to change notification settings - Fork 1.6k
dnn: updated yolov4-tiny hash #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -905,7 +905,7 @@ def get_confirm_token(response): # in case of large files | |||
Model( | |||
name='YOLOv4-tiny', # https://github.com/opencv/opencv/issues/17148 | |||
url='https://github.com/AlexeyAB/darknet/releases/download/darknet_yolo_v4_pre/yolov4-tiny.weights', | |||
sha='d110379b7b86899226b591ad4affc7115f707157', | |||
sha='451caaab22fb9831aa1a5ee9b5ba74a35ffa5dcb', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't override files created by this script (there is 3.4 branch which expects old sha / and tested with old file only).
It should be a new file (with date suffix -YYYY-MM
). Also we need to update tests.
There are 2 links on the release page for yolov4-tiny.weights
:
- https://github.com/AlexeyAB/darknet/releases/download/yolov4/yolov4-tiny.weights
- https://github.com/AlexeyAB/darknet/releases/download/darknet_yolo_v4_pre/yolov4-tiny.weights
But both with the same content (sha1:451caaab22fb9831aa1a5ee9b5ba74a35ffa5dcb
).
BTW, I have a copy of old file with download date 2020-07-03 (sha1:d110379b7b86899226b591ad4affc7115f707157
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've replaced old record with a new one and updated all tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to dates on this page suffix should be -2020-12
(15 Dec 2020): https://github.com/AlexeyAB/darknet/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
darknet_yolo_v4_pre
-> yolov4
in URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Also changed yolov4
URL from Google Drive to GitHub release, the file has same SHA1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yolov4-tiny-2022-12.cfg
-> 2020-12
too
286c1c7
to
10a2d00
Compare
10a2d00
to
e8498a0
Compare
e8498a0
to
090721c
Compare
Merge with opencv/opencv#23008
Looks like this model has been changed in the source - updated file hash