Skip to content

dnn: updated yolov4-tiny hash #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

mshabunin
Copy link
Contributor

@mshabunin mshabunin commented Dec 19, 2022

Merge with opencv/opencv#23008

Looks like this model has been changed in the source - updated file hash

@@ -905,7 +905,7 @@ def get_confirm_token(response): # in case of large files
Model(
name='YOLOv4-tiny', # https://github.com/opencv/opencv/issues/17148
url='https://github.com/AlexeyAB/darknet/releases/download/darknet_yolo_v4_pre/yolov4-tiny.weights',
sha='d110379b7b86899226b591ad4affc7115f707157',
sha='451caaab22fb9831aa1a5ee9b5ba74a35ffa5dcb',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't override files created by this script (there is 3.4 branch which expects old sha / and tested with old file only).
It should be a new file (with date suffix -YYYY-MM). Also we need to update tests.

There are 2 links on the release page for yolov4-tiny.weights:

But both with the same content (sha1:451caaab22fb9831aa1a5ee9b5ba74a35ffa5dcb).

BTW, I have a copy of old file with download date 2020-07-03 (sha1:d110379b7b86899226b591ad4affc7115f707157).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced old record with a new one and updated all tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to dates on this page suffix should be -2020-12 (15 Dec 2020): https://github.com/AlexeyAB/darknet/releases

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darknet_yolo_v4_pre -> yolov4 in URL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.
Also changed yolov4 URL from Google Drive to GitHub release, the file has same SHA1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolov4-tiny-2022-12.cfg -> 2020-12 too

@mshabunin mshabunin force-pushed the fix-yolov4-tiny-hash branch from e8498a0 to 090721c Compare December 22, 2022 08:55
@opencv-pushbot opencv-pushbot merged commit 7189aa0 into opencv:4.x Dec 23, 2022
@mshabunin mshabunin deleted the fix-yolov4-tiny-hash branch December 23, 2022 11:18
@alalek alalek mentioned this pull request Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants