Removed torch7 models #1097
Merged
Removed torch7 models #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also remove the following: |
dkurt
requested changes
Sep 29, 2023
There was a problem hiding this comment.
@alexlyulkov, please remove monster-size https://github.com/alexlyulkov/opencv_extra/blob/al/remove-torch7-from-dnn/testdata/dnn/torch_enet_prob.npy and missed https://github.com/alexlyulkov/opencv_extra/blob/al/remove-torch7-from-dnn/testdata/dnn/generate_torch_models.py
|
@alexlyulkov Friendly reminder. |
asmorkalov
force-pushed
the
al/remove-torch7-from-dnn
branch
from
352c234 to
0f17fd8
Compare
dkurt
approved these changes
Oct 26, 2023
asmorkalov
pushed a commit
to opencv/opencv
that referenced
this pull request
Oct 26, 2023
Remove torch (old torch7) from dnn in 5.x #24294 Merge with opencv/opencv_extra#1097 Completely removed torch (old torch7) from dnn: - removed modules/dnn/src/torch directory that contained torch7 model parser - removed readNetFromTorch() and readTorchBlob() public functions - removed torch7 references from comments and help texts - replaced links to t7 models by links to similar onnx models in js_style_transfer turtorial (similar to https://github.com/opencv/opencv/pull/24245/files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge wtih opencv/opencv#24294
Removed torch7 models, because torch7 will not be supported in OpenCV 5:
removed Openface face recognition .t7 checkpoint
removed ENet image segmentation .net checkpoint
replaced Fast Neutral Style .t7 checkpoint by .onnx checkpoint
(this PR is a copy of the closed PR #1096 but with a proper branch name)