Skip to content

Added WeChatQR-fix ONNX models#1329

Open
omrope79 wants to merge 2 commits into
opencv:5.xfrom
omrope79:wechat-fix
Open

Added WeChatQR-fix ONNX models#1329
omrope79 wants to merge 2 commits into
opencv:5.xfrom
omrope79:wechat-fix

Conversation

@omrope79
Copy link
Copy Markdown

@omrope79 omrope79 commented Apr 1, 2026

Merge with PR opencv/opencv#28746

@asmorkalov
Copy link
Copy Markdown
Contributor

  1. I propose to decouple the data on 2 prs: PR with new layers, PR with WeChat model files.
  2. For all new models we need source of the model and legal information. Small models are usually generated by Torch or ONNXScript or other trusted tool. See https://github.com/opencv/opencv_extra/blob/4.x/testdata/dnn/onnx/generate_onnx_models.py and https://github.com/opencv/opencv_extra/blob/4.x/testdata/dnn/onnx/generate_onnx_models_with_onnxscript.py. For the ONNX model converted from Caffe we need general instruction how to do it. I propose to submit a PR to main repo docs or Wiki page. For the last case you can share google doc with instruction or some other file.

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Apr 2, 2026

Please also provide a short guide of how model converted from Caffe to ONNX

asmorkalov pushed a commit that referenced this pull request Apr 27, 2026
Adds ONNX test models and data for PriorBox and Nearest wechat-fix-layers models #1349

Merge with PR : opencv/opencv#28855

This PR is part 1 of the split from the original PR: Added WeChatQR-fix ONNX models #1329
It adds the required ONNX models and input/output data
@omrope79
Copy link
Copy Markdown
Author

I've removed the extra models from this branch and moved them to a dedicated PR here: #1349. Thanks!

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Apr 29, 2026

@omrope79 does it mean this PR can be closed?

@abhishek-gola
Copy link
Copy Markdown
Contributor

@omrope79 does it mean this PR can be closed?

This PR contains ONNX models for Wechat converted from caffe, required for this PR: opencv/opencv#28746

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Apr 30, 2026

Is that possible to add a guide how to export these models in ONNX? At least in https://github.com/omrope79/opencv-test-models/ README.md

@abhishek-gola
Copy link
Copy Markdown
Contributor

Is that possible to add a guide how to export these models in ONNX? At least in https://github.com/omrope79/opencv-test-models/ README.md

There is this PR (https://huggingface.co/opencv/opencv_contribution/discussions/3/files) on OpenCV hugging face, which has all the scripts.

@asmorkalov
Copy link
Copy Markdown
Contributor

@abhishek-gola Please add requirements.txt to the Higgingface repo. List if required packages is not clean. Also please add documentation page or wiki page about conversion steps. Users most probably have a lot of old models that they want to use with OpenCV 5.

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Apr 30, 2026

Can we use huggingface URLs to download models?

@asmorkalov
Copy link
Copy Markdown
Contributor

Generally yes, but our CI has access issues with it (firewall). It'll be great to have alternative links to, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants