Skip to content

fix large image #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

AleksandrPanov
Copy link
Contributor

@AleksandrPanov AleksandrPanov commented Jun 30, 2022

add load wechat qr detect models

Fixes opencv/opencv_contrib#3282
Test for opencv/opencv_contrib#3287

@AleksandrPanov AleksandrPanov force-pushed the wechat_fix_large_img branch 2 times, most recently from dfb236d to b61be7e Compare June 30, 2022 17:37
@AleksandrPanov AleksandrPanov marked this pull request as ready for review July 5, 2022 11:34
@AleksandrPanov AleksandrPanov force-pushed the wechat_fix_large_img branch 3 times, most recently from 45a6360 to f02ba9a Compare July 5, 2022 15:43
name='wechat_qr_detect',
url='https://raw.githubusercontent.com/WeChatCV/opencv_3rdparty/wechat_qrcode/detect.prototxt',
sha='a6936962139282d300ebbf15a54c2aa94b144bb7',
filename='wechat/detect.prototxt'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wechat => wechat-YYYYMM to support versioning (because download shared directory doesn't support versioning)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes are linked to the last line.

Copy link
Contributor Author

@AleksandrPanov AleksandrPanov Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alalek, I added prefix wechat_2021-01 to path. Could you load model? Then I'll restart the tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloaded

Copy link
Contributor Author

@AleksandrPanov AleksandrPanov Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alalek,
Ubuntu2004-x64:
following models have not been downloaded: wechat_2021-01/detect.prototxt

default build:

C++ exception with description "OpenCV(4.6.0-dev) /build/precommit-contrib_linux64/4.x/opencv/modules/ts/src/ts.cpp:1064: error: (-2:Unspecified error) OpenCV tests: Can't find required data file: ../dnn/wechat_2021-01/detect.prototxt in function 'findData'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others CI are ok

sha='a6936962139282d300ebbf15a54c2aa94b144bb7',
filename='wechat/detect.prototxt'),
Model(
name='wechat_qr_detect',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'wechat_qr_detect'

Avoid duplicate names for different entries. Use this name as prefix only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@AleksandrPanov AleksandrPanov force-pushed the wechat_fix_large_img branch 2 times, most recently from 53f2ebc to 98c1c36 Compare August 8, 2022 16:34
@AleksandrPanov AleksandrPanov requested a review from alalek August 10, 2022 00:31
@AleksandrPanov
Copy link
Contributor Author

@asmorkalov, all checks have passed

@asmorkalov asmorkalov merged commit eafd787 into opencv:4.x Aug 29, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detectAndDecode() in WeChatQRCode not detected QR codes on large images (4032x3024)
3 participants