Add override annotations #1767
Merged
Add override annotations #1767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1767 +/- ##
===========================================
+ Coverage 85.17% 85.70% +0.52%
===========================================
Files 149 149
Lines 15553 16122 +569
===========================================
+ Hits 13248 13817 +569
Misses 2305 2305 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This will enable MyPy to flag methods that no longer override their base class method when refactoring the base class.
Putting this directive in mypy.ini did not work, so move the content of mypy.ini to a mypy-section in pyproject.toml, and then add enable_error_code for explicit-override.
pjonsson
force-pushed
the
add-override-annotations
branch
from
33e2bb2 to
b86b526
Compare
SpacemanPaul
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
This will enable MyPy to flag
methods that no longer override
their base class method when
refactoring the base class.
Proposed changes
Closes #xxxx
Tests added / passed
Fully documented, including
docs/about/whats_new.rstfor all changes📚 Documentation preview 📚: https://datacube-core--1767.org.readthedocs.build/en/1767/