Make configure_s3_access driver aware #2087
Merged
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
reviewed
Aug 4, 2025
| @@ -479,6 +480,7 @@ def configure_s3_access( | |||
| requester_pays: bool = False, | |||
| cloud_defaults: bool = True, | |||
| client=None, | |||
| driver: str | None = None, | |||
There was a problem hiding this comment.
Not having a doc string for a single parameter triggers a warning in my PyCharm and this function doesn't look deprecated, can the parameter get a doc string?
pjonsson
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
As noted in #2081, switching between the legacy and rio drivers results in having to change the way RIO is configured for cloud access.
It is probably possible to get the legacy and rio drivers sharing the same configuration layer eventually, but not in this PR.
Proposed changes
Formally deprecate the
datacube.utils.rio.configure_s3_accessmethod, which just a partial wrapper around the utils.aws version (and has been deprecated in the docstring forever) and migrate tests to use the preferred location.Add an optional
driverargument toconfigure_s3_access. When it is set to "rio", the call is forwarded to the odc-loader version.Closes Requirement for
configure_s3_accessis inconsistent betweenrioanddefaultdrivers #2081Tests added / passed
Pull Request Title will make sense in ODC Release Notes
📚 Documentation preview 📚: https://opendatacube--2087.org.readthedocs.build/en/2087/