Adjust ODH tests to run on FIPS #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I am wondering if we should update the version of torchvision to 0.19.0 as you did in the related codeflare-sdk pr, what do you think?
|
@oksanabaza Could you please update mnist_hpo.py too? |
|
@Fiona-Waters thank you, I will update torchvision version here as well |
oksanabaza
force-pushed
the
adjust-tests
branch
from
4a563bd to
34fe9f7
Compare
|
@abhijeet-dhumal thanks, I also updated mnist_hpo.py file |
oksanabaza
force-pushed
the
adjust-tests
branch
from
34fe9f7 to
a2a0d22
Compare
sutaakar
reviewed
Sep 19, 2024
oksanabaza
force-pushed
the
adjust-tests
branch
from
a2a0d22 to
220dc40
Compare
4 tasks
oksanabaza
force-pushed
the
adjust-tests
branch
from
220dc40 to
878691c
Compare
sutaakar
approved these changes
Sep 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-12442
Description
Made minor fixes to the MNIST dataset download by customizing the MD5 check handling
How Has This Been Tested?
E2E tests should run successfully on the FIPS cluster
Merge criteria: