This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Improve query verification by adding semantic analyzer #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galkk
reviewed
Oct 2, 2019
src/main/java/com/amazon/opendistroforelasticsearch/sql/antlr/OpenDistroSqlAnalyzer.java
Show resolved
Hide resolved
galkk
reviewed
Oct 2, 2019
src/main/java/com/amazon/opendistroforelasticsearch/sql/antlr/StringSimilarity.java
Outdated
Show resolved
Hide resolved
galkk
reviewed
Oct 2, 2019
src/main/java/com/amazon/opendistroforelasticsearch/sql/antlr/StringSimilarity.java
Outdated
Show resolved
Hide resolved
davidcui1225
approved these changes
Oct 2, 2019
galkk
reviewed
Oct 4, 2019
src/main/java/com/amazon/opendistroforelasticsearch/sql/antlr/StringSimilarity.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #151, #82
Description of changes: This PR covers the second part of query verification improvement which include several parts:
The majority of code changes is completed though there are still some to-do items: skip semantic check in unit test, add scope checking, performance impact etc. Sending out this PR to get some feedback earlier.
For reviewers: please read
docs/dev/SemanticAnalysis.mdbefore looking into this big PR. The design doc is not complete yet but should give you many context for the code review.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.