This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Move old SQL code to legacy module #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloe-zh
approved these changes
Jun 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #257
Description of changes: This huge PR is to move all old SQL code at root directory to a new gradle module
legacy. All legacy integration tests are moved tointeg-testmodule. After this, we will start migrating functionalities existing in legacy code to new query engine.Testing:
./gradlew build: pass all checkstyle, jacoco, unit test and integration test./gradlew :integ-test:integTest -Dtests.clustername=mycluster -Dtests.cluster=127.0.0.1:9200 -Dtests.rest.cluster=127.0.0.1:9200: test all IT with local cluster at 9200 port../gradlew :integ-test:integTest -DtestType=doctest: run old doctest to generate SQL docs../gradlew :integ-test:comparisonTest -Dqueries=sanity_integration_tests.txt: run comparison test to compare with other datatbases../gradlew build buildDeb buildRpm --no-daemon --refresh-dependencies --console=plain -Dbuild.snapshot=false: change build command to this one in https://github.com/opendistro-for-elasticsearch/sql/blob/master/.github/workflows/release-workflow.yml.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.