This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New added features.
e.g. Filter - Sort - AnyChild will be optimized as Sort - Filter - AnyChild
e.g. Sort - Relation will be optimized as IndexScan(sort)
Limitation
Currently, the storage engine layer optimzation depend on the Elasticsearch DSL to push down to sort expression. But there are some limitations of Elasticsearch DSL.
Thus, currently, the Sort Operator will push down to Elasticsearch query only when the sort by list include fields only. if the Sort operator include sort expression, the optimization will do nothing, it will still fall back to default memory based implementation.
e.g. source=index | sort abs(a)
the expressionabs(a)
can't be push down to Elasticsearch DSL.Changes
Todo
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.