This repository was archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
Support show and describe statement #907
Merged
penghuo
merged 11 commits into
opendistro-for-elasticsearch:develop
from
penghuo:support-show-statement
Dec 11, 2020
Merged
Support show and describe statement #907
penghuo
merged 11 commits into
opendistro-for-elasticsearch:develop
from
penghuo:support-show-statement
Dec 11, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #907 +/- ##
===========================================
Coverage 99.85% 99.86%
- Complexity 2149 2190 +41
===========================================
Files 216 222 +6
Lines 4851 5028 +177
Branches 323 326 +3
===========================================
+ Hits 4844 5021 +177
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
chloe-zh
approved these changes
Dec 10, 2020
dai-chen
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
harold-wang
pushed a commit
to harold-wang/sql
that referenced
this pull request
Dec 11, 2020
* add frontend support * update core * add elasticsearch * update * add debug * fix UT * update * add comments * add explain * update
penghuo
added a commit
that referenced
this pull request
Dec 15, 2020
* add frontend support * update core * add elasticsearch * update * add debug * fix UT * update * add comments * add explain * update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
#404
Description of changes
SELECT * FROM TABEL
the * should be expanded following the order defined by TABLE schema.Breaking Change
In the legacy engine, if the index has alias, the index name will be returned instead of the alias name. e.g.
The demo_index will be returned as table name instead of demo_alias. In the new engine, we change to retrun the alias name, in the example, the demo_alias will be returned.
Todo
The current implementation doesn't existly follow the semantic definition of LIKE operator. Ideally, the operand of LIKE operator shoud be string literal to represent the match pattern. But the legacy engine use identifier in this case, e.g.
SHOW TABLES LIKE %
. For backward compability reason, we still support it now, but it will be deprecated soon.To Reviewer
I briefly describe the changed files in each module.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.