Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Throw exception when access unknow field type #942

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Dec 16, 2020

Issue #, if available: #941

Description of changes:

  1. Remove the unknow type field from symbol table.
  2. update the limitation doc to callout alias field type can't be used as identifier.
    a. SQL, https://github.com/penghuo/sql/blob/issue-941/docs/user/limitations/limitations.rst
    b. PPL, https://github.com/penghuo/sql/blob/issue-941/docs/experiment/ppl/limitations/limitations.rst

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo requested review from dai-chen and chloe-zh December 16, 2020 20:01
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #942 (f6319df) into develop (ca9f578) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #942   +/-   ##
==========================================
  Coverage      99.86%   99.87%           
- Complexity      2334     2341    +7     
==========================================
  Files            232      232           
  Lines           5376     5389   +13     
  Branches         350      350           
==========================================
+ Hits            5369     5382   +13     
  Misses             5        5           
  Partials           2        2           
Impacted Files Coverage Δ Complexity Δ
...uest/system/ElasticsearchDescribeIndexRequest.java 100.00% <100.00%> (ø) 11.00 <2.00> (+2.00)
...opendistroforelasticsearch/sql/expression/DSL.java 100.00% <0.00%> (ø) 129.00% <0.00%> (+1.00%)
...relasticsearch/sql/expression/NamedExpression.java 100.00% <0.00%> (ø) 6.00% <0.00%> (ø%)
...lasticsearch/sql/expression/text/TextFunction.java 100.00% <0.00%> (ø) 34.00% <0.00%> (+2.00%)
...asticsearch/sql/protocol/response/QueryResult.java 100.00% <0.00%> (ø) 8.00% <0.00%> (+2.00%)
...rch/sql/analysis/ExpressionReferenceOptimizer.java 100.00% <0.00%> (ø) 12.00% <0.00%> (ø%)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9f578...f6319df. Read the comment docs.

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@penghuo penghuo merged commit 8e4cfb7 into opendistro-for-elasticsearch:develop Dec 16, 2020
@penghuo penghuo deleted the issue-941 branch December 16, 2020 21:22
penghuo added a commit to penghuo/sql that referenced this pull request Dec 17, 2020
…search#942)

* Remove the unsupported type from symbol table

* update doc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants