This repository was archived by the owner on Aug 1, 2024. It is now read-only.
Add SQL for creating users and databases #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The included script is idempotent, executed when the mysql container is initialized. This approach is borrowed from docker-library/mysql#18. ECOM-6563
clintonb
approved these changes
Dec 9, 2016
asamolion
referenced
this pull request
in edly-io/devstack
Apr 24, 2019
# This is the 1st commit message: ADD: add clone feature for edly wp repos # The commit message #2 will be skipped: # ADD: add wordpress clone support # The commit message #3 will be skipped: # WIP: add WP container # The commit message #4 will be skipped: # ADD: add config for wordpress plugins, themes and env # The commit message #5 will be skipped: # MOD: refine the config for WP container # The commit message #6 will be skipped: # ADD: add custom build script for edly/wp docker image # The commit message #7 will be skipped: # FIX: remove unnecessary keys # The commit message #8 will be skipped: # FIX: add correct settings in wp-config.php # The commit message #9 will be skipped: # MOD: add custom config for WP image # The commit message #10 will be skipped: # FIX: use proper docker image # The commit message #11 will be skipped: # ADD: add must install wp plugins # The commit message #12 will be skipped: # FIX: fix version of wordpress docker image
kdmccormick
pushed a commit
that referenced
this pull request
May 28, 2020
…ine/fixes2 Set COMPOSE_FILE environment variable in Makefile. I read over https://docs.docker.com/compose/reference/envvars/#compose_file and it seems fine.
kdmccormick
added a commit
that referenced
this pull request
Jul 30, 2021
lms now depends on frontend-app-learning; previously, the converse was true. Running `make dev.up.lms` will start the frontend-app-learning container. This change has been made for all Devstack frontends/backends. This is breaking in that `make dev.up.frontend-app-*` is no longer the best way to start a frontend from a clean state, since it will not start related backend service(s). Instead, the backend service should be started, which will cause all related frontend apps to be started as dependencies. See included ADR (#4) for more context. Also includes some doc updates related to this change. TNL-8407
kdmccormick
added a commit
that referenced
this pull request
Aug 3, 2021
lms now depends on frontend-app-learning; previously, the converse was true. Running `make dev.up.lms` will start the frontend-app-learning container. This change has been made for all Devstack frontends/backends. This is breaking in that `make dev.up.frontend-app-*` is no longer the best way to start a frontend from a clean state, since it will not start related backend service(s). Instead, the backend service should be started, which will cause all related frontend apps to be started as dependencies. See included ADR (#4) for more context. Also includes some doc updates related to this change. TNL-8407
kdmccormick
added a commit
that referenced
this pull request
Aug 3, 2021
lms now depends on frontend-app-learning; previously, the converse was true. Running `make dev.up.lms` will start the frontend-app-learning container. This change has been made for all Devstack frontends/backends. This is breaking in that `make dev.up.frontend-app-*` is no longer the best way to start a frontend from a clean state, since it will not start related backend service(s). Instead, the backend service should be started, which will cause all related frontend apps to be started as dependencies. See included ADR (#4) for more context. Also includes some doc updates related to this change. TNL-8407
kdmccormick
added a commit
that referenced
this pull request
Aug 9, 2021
…ntends This commit made it so frontend services were started as dependencies whenever LMS (or other services) were started. The increased number of Docker containers is causing resource depletion for at least one developer. As a short-term fix, we will revert this commit. This reverts most of commit 54fb57f, although it leaves in place the changes to docs/workflow.rst, as they are still relevant. It also keeps ADR #4, but amends it.
kdmccormick
added a commit
that referenced
this pull request
Aug 9, 2021
…ntends This commit made it so frontend services were started as dependencies whenever LMS (or other services) were started. The increased number of Docker containers is causing resource depletion for at least one developer. As a short-term fix, we will revert this commit. This reverts most of commit 54fb57f, although it leaves in place the changes to docs/workflow.rst, as they are still relevant. It also keeps ADR #4, but amends it.
kdmccormick
added a commit
that referenced
this pull request
Aug 9, 2021
…ntends (#815) This commit made it so frontend services were started as dependencies whenever LMS (or other services) were started. The increased number of Docker containers is causing resource depletion for at least one developer. As a short-term fix, we will revert this commit. This reverts most of commit 54fb57f, although it leaves in place the changes to docs/workflow.rst, as they are still relevant. It also keeps ADR #4, but amends it.
nsprenkle
pushed a commit
that referenced
this pull request
Nov 21, 2023
lms now depends on frontend-app-learning; previously, the converse was true. Running `make dev.up.lms` will start the frontend-app-learning container. This change has been made for all Devstack frontends/backends. This is breaking in that `make dev.up.frontend-app-*` is no longer the best way to start a frontend from a clean state, since it will not start related backend service(s). Instead, the backend service should be started, which will cause all related frontend apps to be started as dependencies. See included ADR (#4) for more context. Also includes some doc updates related to this change. TNL-8407
nsprenkle
pushed a commit
that referenced
this pull request
Nov 21, 2023
…ntends (#815) This commit made it so frontend services were started as dependencies whenever LMS (or other services) were started. The increased number of Docker containers is causing resource depletion for at least one developer. As a short-term fix, we will revert this commit. This reverts most of commit 54fb57f, although it leaves in place the changes to docs/workflow.rst, as they are still relevant. It also keeps ADR #4, but amends it.
cruise-control-service
pushed a commit
to eduNEXT/devstack
that referenced
this pull request
Feb 26, 2024
…ebase Merge juniper-rebase into master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included script is idempotent, executed when the mysql container is initialized. This approach is borrowed from docker-library/mysql#18.
ECOM-6563
@clintonb @jmbowman @davec-edx