This repository was archived by the owner on Nov 4, 2024. It is now read-only.
fix: update log statements #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following PR (for REV-2575), for the order history page I've added logic to check the waffle flag value from ecommerce when deciding whether to call the new commerce-coordinator endpoint:
#181
The change includes debugging statements logged to the console to help with testing once commerce-coordinator is available in stage and prod. During cleanup, I'd moved a debugging statement down where the value had changed, so I'm putting that back here, so we have one to (correctly) tell us the results we got from ecommerce endpoint, and another to tell us the results if that data was replaced with results from the commerce-coordinator endpoint.
Testing notes:
in your local ecommerce admin, add waffle flag 'enable_hoist_order_history' with value Yes
start up locally: devstack with ecommerce, commerce-coordinator, and frontend-app-ecommerce
log in to localhost with a user who has orders
go to the order history page: http://localhost:1996/orders
Result: now the console logging statements happen at the right time: the ecommerce one after we get results from the ecommerce endpoint, then the commerce-coordinator one if/after we call out to that.