Skip to content
This repository was archived by the owner on Nov 4, 2024. It is now read-only.

Conversation

@dianekaplan
Copy link
Contributor

@dianekaplan dianekaplan commented May 11, 2022

In the following PR (for REV-2575), for the order history page I've added logic to check the waffle flag value from ecommerce when deciding whether to call the new commerce-coordinator endpoint:
#181

The change includes debugging statements logged to the console to help with testing once commerce-coordinator is available in stage and prod. During cleanup, I'd moved a debugging statement down where the value had changed, so I'm putting that back here, so we have one to (correctly) tell us the results we got from ecommerce endpoint, and another to tell us the results if that data was replaced with results from the commerce-coordinator endpoint.

Testing notes:
in your local ecommerce admin, add waffle flag 'enable_hoist_order_history' with value Yes
start up locally: devstack with ecommerce, commerce-coordinator, and frontend-app-ecommerce
log in to localhost with a user who has orders
go to the order history page: http://localhost:1996/orders
Result: now the console logging statements happen at the right time: the ecommerce one after we get results from the ecommerce endpoint, then the commerce-coordinator one if/after we call out to that.

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #184 (eeb04e7) into master (47c06a3) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   48.78%   48.78%           
=======================================
  Files          15       15           
  Lines         164      164           
  Branches       28       28           
=======================================
  Hits           80       80           
  Misses         79       79           
  Partials        5        5           
Impacted Files Coverage Δ
src/order-history/service.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47c06a3...eeb04e7. Read the comment docs.

@dianekaplan dianekaplan merged commit 1cd09da into master May 11, 2022
@dianekaplan dianekaplan deleted the dianekaplan/REV-2575_update_log_statement branch May 11, 2022 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants