Skip to content

Make Upgrade + Update Django to latest patch version. #18705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Aug 1, 2018

@@ -229,14 +229,15 @@ pa11ycrawler==1.6.2
packaging==17.1
parsel==1.5.0
path.py==8.2.1
pathlib2==2.3.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to start switching from path.py to this; it's a backport of the similar functionality added to Python 3.4. Once we're on Python3 exclusively, we could drop the dependency altogether.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't this used to print which dependency it was getting pulled in for? Did we turn that functionality off?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That information is in testing.txt, the first file to pull it in. The info isn't duplicated here because we used -r testing.txt as an input, so it's considered a direct requirement here.

@@ -167,7 +167,7 @@ mock==1.0.1
mongoengine==0.10.0
mysql-python==1.2.5
networkx==1.7
newrelic==4.0.0.99
newrelic==4.2.0.100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I'll be sending out some follow-up mail to turn this on everywhere, they announced it yesterday.

@jmbowman
Copy link
Contributor

jmbowman commented Aug 1, 2018

@feanil Looks like we'll need to cap the pytest version until pytest-dev/pytest#3749 is fixed in a new release (that caused the python tests failure).

@feanil feanil force-pushed the feanil/make_ugprade_and_update_django branch from f88784f to 34a93b4 Compare August 1, 2018 16:00
@feanil
Copy link
Contributor Author

feanil commented Aug 1, 2018

@jmbowman I just omitted the pytest upgrade for now, do you think I should actively pin it in the .in file?

Copy link
Contributor

@jmbowman jmbowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, otherwise it'll keep tripping up people running make upgrade until the new release is out. Also, we don't technically need pathlib2 until we do that pytest upgrade.

@@ -229,14 +229,15 @@ pa11ycrawler==1.6.2
packaging==17.1
parsel==1.5.0
path.py==8.2.1
pathlib2==2.3.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That information is in testing.txt, the first file to pull it in. The info isn't duplicated here because we used -r testing.txt as an input, so it's considered a direct requirement here.

@feanil feanil force-pushed the feanil/make_ugprade_and_update_django branch 2 times, most recently from 3cbc0ab to 4c4bad0 Compare August 1, 2018 19:36
There are issues in the newest version that we don't want to pick up yet.
@feanil feanil force-pushed the feanil/make_ugprade_and_update_django branch from 4c4bad0 to d5dfbb7 Compare August 1, 2018 21:10
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@jmbowman jmbowman merged commit 8a55890 into master Aug 1, 2018
@feanil feanil deleted the feanil/make_ugprade_and_update_django branch August 2, 2018 13:44
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, August 03, 2018.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/STAGE_edxapp_M-D

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants