-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Make Upgrade
+ Update Django to latest patch version.
#18705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
requirements/edx/development.txt
Outdated
@@ -229,14 +229,15 @@ pa11ycrawler==1.6.2 | |||
packaging==17.1 | |||
parsel==1.5.0 | |||
path.py==8.2.1 | |||
pathlib2==2.3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to start switching from path.py
to this; it's a backport of the similar functionality added to Python 3.4. Once we're on Python3 exclusively, we could drop the dependency altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't this used to print which dependency it was getting pulled in for? Did we turn that functionality off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That information is in testing.txt
, the first file to pull it in. The info isn't duplicated here because we used -r testing.txt
as an input, so it's considered a direct requirement here.
@@ -167,7 +167,7 @@ mock==1.0.1 | |||
mongoengine==0.10.0 | |||
mysql-python==1.2.5 | |||
networkx==1.7 | |||
newrelic==4.0.0.99 | |||
newrelic==4.2.0.100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new support for distributed tracing looks potentially useful: https://docs.newrelic.com/docs/apm/distributed-tracing/getting-started/transition-guide-distributed-tracing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I'll be sending out some follow-up mail to turn this on everywhere, they announced it yesterday.
@feanil Looks like we'll need to cap the pytest version until pytest-dev/pytest#3749 is fixed in a new release (that caused the python tests failure). |
f88784f
to
34a93b4
Compare
@jmbowman I just omitted the pytest upgrade for now, do you think I should actively pin it in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, otherwise it'll keep tripping up people running make upgrade
until the new release is out. Also, we don't technically need pathlib2
until we do that pytest upgrade.
requirements/edx/development.txt
Outdated
@@ -229,14 +229,15 @@ pa11ycrawler==1.6.2 | |||
packaging==17.1 | |||
parsel==1.5.0 | |||
path.py==8.2.1 | |||
pathlib2==2.3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That information is in testing.txt
, the first file to pull it in. The info isn't duplicated here because we used -r testing.txt
as an input, so it's considered a direct requirement here.
3cbc0ab
to
4c4bad0
Compare
There are issues in the newest version that we don't want to pick up yet.
4c4bad0
to
d5dfbb7
Compare
Your PR has finished running tests. There were no failures. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, August 03, 2018. |
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/STAGE_edxapp_M-D |
EdX Release Notice: This PR has been deployed to the production environment. |
django changelog: https://www.djangoproject.com/weblog/2018/aug/01/security-releases/
django-mysql Changelog: https://pypi.org/project/django-mysql/
newrelic changelog: https://docs.newrelic.com/docs/release-notes/agent-release-notes/python-release-notes
voluptous changelog: https://github.com/alecthomas/voluptuous/blob/master/CHANGELOG.md
edx-drf-extension "changelog": https://github.com/edx/edx-drf-extensions/releases
edx-val "changelog": https://github.com/edx/edx-val/releases
Did not pull the changelog for any of the non-production requirements.