feat: upgrade to react 18 #1466

brian-smith-tcril · 2025-03-31T20:19:09Z

Part 2 of #1422

codecov · 2025-03-31T20:21:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (2d73030) to head (9baecdb).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1466   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files         124      124           
  Lines        2299     2299           
  Branches      642      646    +4     
=======================================
  Hits         2016     2016           
  Misses        274      274           
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

open-craft-grove · 2025-03-31T21:22:37Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-04-01T05:06:40Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

src/index.jsx

open-craft-grove · 2025-04-01T18:32:33Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-04-04T08:32:34Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

arbrandes

Looks good! 👍🏼

* fix(deps): update dependency @edx/frontend-platform to v8.3.2 (#1454) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency babel-plugin-formatjs to v10.5.36 (#1455) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-platform to v8.3.3 (#1456) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency algoliasearch-helper to v3.24.3 (#1457) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @openedx/frontend-build to v14.3.3 (#1459) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @openedx/paragon to v22.16.1 (#1460) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update `@openedx` dependencies to versions that support React 18 (#1458) * docs: Update migrated edx.rtd links to docs.openedx.org * docs: Add instructions on using Tutor for development * chore(deps): update dependency babel-plugin-formatjs to v10.5.37 (#1461) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @openedx/paragon to v22.16.2 (#1462) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @openedx/frontend-build to v14.4.1 (#1464) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: properly set background color for floating labels (#1468) * fix(deps): update dependency @edx/frontend-platform to v8.3.4 (#1471) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: upgrade to react 18 (#1466) * chore(deps): update dependency @openedx/frontend-build to v14.5.0 (#1474) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: remove husky 🪓🐶 We remove husky, which is triggering pre-push git hooks, including running "npm lint". This is causing failures when building Docker images, because "npm clean-install --omit=dev" automatically triggers "npm prepare", which attemps to run "husky". But husky is not listed in the build dependencies, only in devDependencies. As a consequence, package installation is failing with the following error: 14.13 > @edx/[email protected] prepare 14.13 > husky install 14.13 14.15 sh: 1: husky: not found Similar to: openedx/frontend-app-learning#1622 * chore(deps): update dependency @openedx/frontend-build to v14.6.0 (#1477) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency algoliasearch-helper to v3.25.0 (#1478) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency core-js to v3.42.0 (#1479) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency babel-plugin-formatjs to v10.5.38 (#1480) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-platform to v8.3.5 (#1481) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-platform to v8.3.6 (#1482) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-platform to v8.3.7 (#1484) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update react-router monorepo to v6.30.1 (#1486) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @openedx/paragon to v22.18.0 (#1487) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @openedx/paragon to v22.18.1 (#1488) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-platform to v8.3.8 (#1489) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @openedx/paragon to v22.18.2 (#1490) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @openedx/paragon to v22.20.0 (#1491) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-platform to v8.3.9 (#1492) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency core-js to v3.43.0 (#1493) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-platform to v8.4.0 (#1494) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest to v30 (#1495) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @openedx/paragon to v22.20.1 (#1496) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency babel-plugin-formatjs to v10.5.39 (#1499) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @openedx/paragon to v22.20.2 (#1500) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency algoliasearch-helper to v3.26.0 (#1501) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @openedx/frontend-build to v14.6.1 (#1503) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat!: add design tokens support (#1504) BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <[email protected]> * chore(deps): update dependency jest to v30.0.1 (#1506) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest to v30.0.2 (#1507) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency algoliasearch to v4.25.0 (#1508) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-import to v2.32.0 (#1509) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency algoliasearch to v4.25.2 (#1510) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest to v30.0.3 (#1513) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @openedx/paragon to v23.13.0 (#1514) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest to v30.0.4 (#1516) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @openedx/paragon to v23.14.0 (#1517) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: component destory issue after react 18 upgrade * fix: fixed lint issue --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Brian Smith <[email protected]> Co-authored-by: sarina <[email protected]> Co-authored-by: Régis Behmo <[email protected]> Co-authored-by: Adolfo R. Brandes <[email protected]> Co-authored-by: Diana Olarte <[email protected]> Co-authored-by: eemaanamir <[email protected]>

brian-smith-tcril mentioned this pull request Mar 31, 2025

React 18 Upgrade #1422

Closed

brian-smith-tcril added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Mar 31, 2025

brian-smith-tcril marked this pull request as ready for review April 1, 2025 04:24

brian-smith-tcril requested a review from a team as a code owner April 1, 2025 04:24

brian-smith-tcril force-pushed the react-18 branch from fec8886 to a9e8440 Compare April 1, 2025 04:25

brian-smith-tcril commented Apr 1, 2025

View reviewed changes

src/index.jsx Outdated Show resolved Hide resolved

brian-smith-tcril force-pushed the react-18 branch from a9e8440 to 9a42717 Compare April 1, 2025 17:57

feat: upgrade to react 18

9baecdb

brian-smith-tcril force-pushed the react-18 branch from 9a42717 to 9baecdb Compare April 4, 2025 07:48

arbrandes approved these changes Apr 4, 2025

View reviewed changes

brian-smith-tcril merged commit 38a1924 into openedx:master Apr 4, 2025
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: upgrade to react 18 #1466

feat: upgrade to react 18 #1466

brian-smith-tcril commented Mar 31, 2025

Uh oh!

codecov bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

open-craft-grove commented Mar 31, 2025

Uh oh!

open-craft-grove commented Apr 1, 2025

Uh oh!

Uh oh!

open-craft-grove commented Apr 1, 2025

Uh oh!

open-craft-grove commented Apr 4, 2025

Uh oh!

arbrandes left a comment

Uh oh!

Uh oh!

Uh oh!

feat: upgrade to react 18 #1466

feat: upgrade to react 18 #1466

Conversation

brian-smith-tcril commented Mar 31, 2025

Uh oh!

codecov bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

open-craft-grove commented Mar 31, 2025

Uh oh!

open-craft-grove commented Apr 1, 2025

Uh oh!

Uh oh!

open-craft-grove commented Apr 1, 2025

Uh oh!

open-craft-grove commented Apr 4, 2025

Uh oh!

arbrandes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 31, 2025 •

edited

Loading