This repository was archived by the owner on Nov 6, 2020. It is now read-only.
[ethcore]: reduce re-exports #11059
Merged
[ethcore]: reduce re-exports #11059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last piece of refactoring to close #10130 after work done by @dvdplm et. al After this PR, we have the following re-exports from other crates in `non-testbuilds`: - evm::VMType (client) - ethcore_miner::local_accounts::LocalAccounts (miner) - ethcore_miner::pool::PendingOrdering (miner) I think the miner re-exports make sense (closely tied to the module) and `VMType` (related to module but not closely)
niklasad1
added
A0-pleasereview 🤓
tomusdrw
approved these changes
Sep 16, 2019
dvdplm
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
LGTM module minor nit.
Good stuff, I think that while reexports can be useful now and then, we're better off without them in parity-ethereum: they make it tricky to navigate the code base. Actually finding out what depends on what is non-trivial. I have it on my todo-list to see if any of the crates that currently depend on ethcore could actually be "upgraded" to use it only as a dev-dependency. I suspect that a few could (and further down my todo-list is to investigate if the test-helpers in ethcore could/should be extracted).
ordian
added
A8-looksgood 🦄
dvdplm
added a commit
that referenced
this pull request
Sep 18, 2019
* master: [ethcore]: move client test types to test-helpers (#11062) [sync]: remove unused dependencies or make dev (#11061) [ethcore]: reduce re-exports (#11059) [evmbin] fix time formatting (#11060) Update hardcoded headers (foundation, classic, kovan, xdai, ewc, ...) (#11053) cargo update -p eth-secp256k1 (#11052)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last piece of refactoring to close #10130 after work done by @dvdplm et. al
After this PR, we have the following re-exports from other crates in
non-testbuilds:I think the miner re-exports make sense (closely tied to the module) and
VMType(related to module but not closely)