Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Fix compile warnings #11595

Merged
merged 4 commits into from
Apr 3, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions parity/account_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ mod accounts {
Ok(None)
}

pub fn private_tx_signer(_account_provider: Arc<AccountProvider>, _passwords: &[Password]) -> Result<Arc<::ethcore_private_tx::Signer>, String> {
pub fn private_tx_signer(_account_provider: Arc<dyn AccountProvider>, _passwords: &[Password]) -> Result<Arc<::ethcore_private_tx::Signer>, String> {
Ok(Arc::new(::ethcore_private_tx::DummySigner))
}

pub fn accounts_list(_account_provider: Arc<AccountProvider>) -> Arc<Fn() -> Vec<Address> + Send + Sync> {
pub fn accounts_list(_account_provider: Arc<dyn AccountProvider>) -> Arc<Fn() -> Vec<Address> + Send + Sync> {
Arc::new(|| vec![])
}
}
Expand Down
1 change: 1 addition & 0 deletions rpc/src/v1/helpers/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ mod codes {
pub const REQUEST_REJECTED_LIMIT: i64 = -32041;
pub const REQUEST_NOT_FOUND: i64 = -32042;
pub const ENCRYPTION_ERROR: i64 = -32055;
#[cfg(any(test, feature = "accounts"))]
pub const ENCODING_ERROR: i64 = -32058;
pub const FETCH_ERROR: i64 = -32060;
pub const NO_LIGHT_PEERS: i64 = -32065;
Expand Down
4 changes: 3 additions & 1 deletion rpc/src/v1/types/derivation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,16 @@ pub enum DerivationType {
}

/// Derivation request by hash
#[cfg_attr(not(any(test, feature = "accounts")), allow_unused)]
#[derive(Deserialize)]
pub struct DeriveHash {
hash: H256,
#[serde(rename = "type")]
d_type: DerivationType,
}

/// Node propertoes in hierarchical derivation request
/// Node properties in hierarchical derivation request
#[cfg_attr(not(any(test, feature = "accounts")), allow_unused)]
#[derive(Deserialize)]
pub struct DeriveHierarchicalItem {
index: u64,
Expand Down