fixup! only start background task on active forwarding configuration

Author: SergioSim

src/ralph/api/routers/statements.py

@@ -15,7 +15,7 @@
     status,
 )
 
-from ralph.api.forwarding import forward_xapi_statements
+from ralph.api.forwarding import forward_xapi_statements, get_active_xapi_forwardings
 from ralph.backends.database.base import BaseDatabase, StatementParameters
 from ralph.conf import settings
 from ralph.exceptions import BackendException, BadFormatException
@@ -261,7 +261,10 @@ async def post(
             detail="Duplicate statement IDs in the list of statements",
         )
 
-    background_tasks.add_task(forward_xapi_statements, list(statements_dict.values()))
+    if get_active_xapi_forwardings():
+        background_tasks.add_task(
+            forward_xapi_statements, list(statements_dict.values())
+        )
 
     try:
         statements_ids_result = DATABASE_CLIENT.query_statements_by_ids(statements_ids)

tests/api/test_statements_post.py

@@ -342,6 +342,55 @@ def query_statements_by_ids_mock(*args, **kwargs):
     assert response.json() == {"detail": "xAPI statements query failed"}
 
 
+@pytest.mark.parametrize("backend", [get_es_test_backend, get_mongo_test_backend])
+def test_post_statements_list_without_statement_forwarding(
+    backend, auth_credentials, monkeypatch, es, mongo
+):
+    """Tests the post statements API route, given an empty forwarding configuration,
+    should not start the forwarding background task.
+    """
+    # pylint: disable=invalid-name,unused-argument
+
+    spy = {}
+
+    def spy_mock_forward_xapi_statements(_):
+        """Mocks the forward_xapi_statements; spies over whether it has been called."""
+
+        spy["error"] = "forward_xapi_statements should not have been called!"
+
+    monkeypatch.setattr(
+        "ralph.api.routers.statements.forward_xapi_statements",
+        spy_mock_forward_xapi_statements,
+    )
+    monkeypatch.setattr(
+        "ralph.api.routers.statements.get_active_xapi_forwardings", lambda: []
+    )
+    monkeypatch.setattr("ralph.api.routers.statements.DATABASE_CLIENT", backend())
+
+    statement = {
+        "actor": {
+            "account": {
+                "homePage": "https://example.com/homepage/",
+                "name": str(uuid4()),
+            },
+            "objectType": "Agent",
+        },
+        "id": str(uuid4()),
+        "object": {"id": "https://example.com/object-id/1/"},
+        "timestamp": "2022-06-22T08:31:38Z",
+        "verb": {"id": "https://example.com/verb-id/1/"},
+    }
+
+    response = client.post(
+        "/xAPI/statements/",
+        headers={"Authorization": f"Basic {auth_credentials}"},
+        json=statement,
+    )
+
+    assert response.status_code == 200
+    assert "error" not in spy
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "forwarding_backend", [get_es_test_backend, get_mongo_test_backend]