Skip to content

8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java #24750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

myankelev
Copy link
Member

@myankelev myankelev commented Apr 18, 2025

Provider is now added to the Security before the test


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24750/head:pull/24750
$ git checkout pull/24750

Update a local copy of the PR:
$ git checkout pull/24750
$ git pull https://git.openjdk.org/jdk.git pull/24750/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24750

View PR using the GUI difftool:
$ git pr show -t 24750

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24750.diff

Using Webrev

Link to Webrev Comment

…vider.java

test is fixed, provider is now added to the Security before the test
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2025

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java Apr 18, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2025
@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@myankelev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 18, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review security [email protected]
Development

Successfully merging this pull request may close these issues.

1 participant