Skip to content

8361569: [JVMCI] Further refine JVMCI-compiled nmethod that should not collect deoptimization profile #26192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented Jul 8, 2025

In #25356 we prevent all non-CompilerBroker JVMCI compilations from collecting deoptimiztaion profiles. This causes some regression in Graal's whitebox unit tests, some of which employ non-CompilerBroker compilations to test deoptimiztaions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361569: [JVMCI] Further refine JVMCI-compiled nmethod that should not collect deoptimization profile (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26192/head:pull/26192
$ git checkout pull/26192

Update a local copy of the PR:
$ git checkout pull/26192
$ git pull https://git.openjdk.org/jdk.git pull/26192/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26192

View PR using the GUI difftool:
$ git pr show -t 26192

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26192.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2025

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361569: [JVMCI] Further refine JVMCI-compiled nmethod that should not collect deoptimization profile

Reviewed-by: dnsimon, gdub

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 7282f68: 8361216: Do not fork javac in J2DBench ant build
  • 6e20338: 8358533: Improve performance of java.io.Reader.readAllLines
  • 6249259: 8361299: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@mur47x111 The following labels will be automatically applied to this pull request:

  • graal
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 8, 2025

Copy link
Member

@dougxc dougxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 8, 2025
@mur47x111 mur47x111 changed the title 8361569: [JVMCI] Further refine JVMCI-compiled nmethod that should not collect deoptimiztaion profile 8361569: [JVMCI] Further refine JVMCI-compiled nmethod that should not collect deoptimization profile Jul 9, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 9, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 9, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 9, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 9, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 9, 2025
@mur47x111
Copy link
Contributor Author

Thanks for the review! Passed Tier1-3
/integrate

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

Going to push as commit 6681fc7.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 7282f68: 8361216: Do not fork javac in J2DBench ant build
  • 6e20338: 8358533: Improve performance of java.io.Reader.readAllLines
  • 6249259: 8361299: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 9, 2025
@openjdk openjdk bot closed this Jul 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@mur47x111 Pushed as commit 6681fc7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants