8360411: [TEST] open/test/jdk/java/io/File/MaxPathLength.java Refactor extract method to encapsulate Windows specific test logic #26193
Conversation
… extract method to encapsulate Windows specific
|
Hi @DarraghConway, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user DarraghConway" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
DarraghConway
changed the title
|
❗ This change is not yet ready to be integrated. |
|
@DarraghConway The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/covered |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
| if (isWindows) { | ||
| String name = fileName; | ||
| while (name.length() < MAX_LENGTH) { | ||
| testLongPath (20, name, false); |
There was a problem hiding this comment.
Nitpick: do you think there is a need for a space before the (? Looks odd imo. But as the whole file uses this, I'm fine with you leaving this as is
There was a problem hiding this comment.
Yeah, was just being coherent
| while (name.length() < MAX_LENGTH) { | ||
| testLongPath (20, name, false); | ||
| testLongPath (20, name, true); | ||
| name = getNextName(name); |
There was a problem hiding this comment.
Name doesn't seem to be used after. Do you think it might be beneficial to add an assert here to check if the result is the same as expected ?
Same applies to the main method
There was a problem hiding this comment.
I agree it would be beneficial.
Would this be a valid assert to add after those while loops?
assert name.length() >= MAX_LENGTH : "Unexpected final name length: " + name.length();
Refactored extract method to encapsulate Windows specific test logic
Progress
Error
Integration blocker
8360411. Please make sure it exists and is accessible.Issue
8360411.Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26193/head:pull/26193$ git checkout pull/26193Update a local copy of the PR:
$ git checkout pull/26193$ git pull https://git.openjdk.org/jdk.git pull/26193/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26193View PR using the GUI difftool:
$ git pr show -t 26193Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26193.diff