Skip to content

8359497: IllegalArgumentException thrown by SourceCodeAnalysisImpl.highlights() #26446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jul 23, 2025

When JShell computes highlights, it uses the javac' lexer to detect keywords. But, if there's a lexical error in the input, the lexer will try to report an error, but that will with an exception, as there's no input file set. This PR:

  • sets a source to Log so that the attempt to report the error will not fail
  • sets a DiagnosticListener so that the error is ignored (as the error is not important, this lexer is only used to detect keyword).

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359497: IllegalArgumentException thrown by SourceCodeAnalysisImpl.highlights() (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26446/head:pull/26446
$ git checkout pull/26446

Update a local copy of the PR:
$ git checkout pull/26446
$ git pull https://git.openjdk.org/jdk.git pull/26446/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26446

View PR using the GUI difftool:
$ git pr show -t 26446

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26446.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2025

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 23, 2025
@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 23, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant